Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53-targets): InterfaceVpcEndpointTarget incorrectly accepts an imported endpoint #21523

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(route53-targets): InterfaceVpcEndpointTarget incorrectly accepts an imported endpoint #21523

merged 2 commits into from
Aug 9, 2022

Commits on Aug 9, 2022

  1. fix(route53-targets): InterfaceVpcEndpoint target requires a 

    InterfaceVpcEndpoint

The `InterfaceVpcEndpointTarget` currently accepts an imported endpoint
`IInterfaceVpcEndpoint`, but the actual implementation requires access
to the `CfnVPCEndpoint` resource which is only available from the
`InterfaceVpcEndpoint`.

This appears as breaking, but I don't think it should be considered as
breaking since you can currently _only_ pass a `InterfaceVpcEndpoint`.

I thought about adding support for `IInterfaceVpcEndpoint`, but that
would require updating the `fromxxx` method to take the route53 zone and
the DNS name for the endpoint. If you need to know those values to use
this construct then you might as well just create a normal Route53
record.

closes #10432
    @corymhall
    corymhall committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b5311fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into corymhall/route53-targets/interface-vpc-endp… 

    …oint
    @corymhall
    corymhall authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    1fa03f1 View commit details
    Browse the repository at this point in the history