-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes #8017
Conversation
Removes test suggesting that DomainName.addBasePathMapping() will work for all cases
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…mainNameAttributes Removes test suggesting that DomainName.addBasePathMapping() will work for all cases ### Commit Message docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes (aws#8017) Replace "In most cases" with a notice about imported DomainNames ### End Commit Message ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Removes test suggesting that DomainName.addBasePathMapping() will work for all cases
Commit Message
docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes (#8017)
Replace "In most cases" with a notice about imported DomainNames
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license