Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes #8017

Merged
merged 5 commits into from
May 19, 2020
Merged

docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes #8017

merged 5 commits into from
May 19, 2020

Conversation

baer
Copy link
Contributor

@baer baer commented May 15, 2020

Removes test suggesting that DomainName.addBasePathMapping() will work for all cases

Commit Message

docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes (#8017)

Replace "In most cases" with a notice about imported DomainNames

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Removes test suggesting that DomainName.addBasePathMapping() will work for all cases
@mergify
Copy link
Contributor

mergify bot commented May 15, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@baer baer changed the title Remove misleading statement about DomainName.fromDomainNameAttributes docs: remove misleading statement about DomainName.fromDomainNameAttributes May 15, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ad8c164
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB changed the title docs: remove misleading statement about DomainName.fromDomainNameAttributes docs(api-gateway): remove misleading statement about DomainName.fromDomainNameAttributes May 15, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d419fc1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f5ed3d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title docs(api-gateway): remove misleading statement about DomainName.fromDomainNameAttributes docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes May 19, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d60afa1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bcb072b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a9d8035 into aws:master May 19, 2020
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this pull request May 22, 2020
…mainNameAttributes

Removes test suggesting that DomainName.addBasePathMapping() will work for all cases

### Commit Message
docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes (aws#8017)

Replace "In most cases" with a notice about imported DomainNames
### End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants