Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes #8017

Merged
merged 5 commits into from
May 19, 2020
Merged

docs(apigateway): remove misleading statement about DomainName.fromDomainNameAttributes #8017

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad8c164
Clarify documentation for imported DomainName
baer May 15, 2020
d419fc1
Remove extra whitespace at EOL
baer May 18, 2020
f5ed3d1
Merge branch 'master' into addBasePathMapping-documentation
baer May 18, 2020
d60afa1
Update packages/@aws-cdk/aws-apigateway/lib/base-path-mapping.ts
May 19, 2020
bcb072b
Merge branch 'master' into addBasePathMapping-documentation
mergify[bot] May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-apigateway/lib/base-path-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export interface BasePathMappingProps extends BasePathMappingOptions {
* This resource creates a base path that clients who call your API must use in
* the invocation URL.
*
* In most cases, you will probably want to use
* `DomainName.addBasePathMapping()` to define mappings.
* Unless you're importing a domain with `DomainName.fromDomainNameAttributes()`,
* you can use `DomainName.addBasePathMapping()` to define mappings.
*/
export class BasePathMapping extends Resource {
constructor(scope: Construct, id: string, props: BasePathMappingProps) {
Expand Down