Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scan-build errors #1856

Open
ghenry opened this issue Sep 17, 2024 · 2 comments
Open

scan-build errors #1856

ghenry opened this issue Sep 17, 2024 · 2 comments

Comments

@ghenry
Copy link

ghenry commented Sep 17, 2024 •
edited
Loading

Problem:

My scan-build run is reporting 43 errors, mainly because I haven't exclude my cargo dir:

https://github.com/SentryPeer/SentryPeer/actions/runs/10900103619/job/30246983229

I presume you're doing this too. But screenshot attached. A division by zero error in there too.

Thanks.

Screenshot 2024-09-17 at 14-48-05 sentrypeer - scan-build results
@ghenry
Copy link
Author

ghenry commented Sep 17, 2024

Screenshot uploaded.

@justsmth justsmth mentioned this issue Sep 19, 2024
Merged
@justsmth
Copy link
Contributor

Thanks for reporting! We're looking into these.

justsmth added a commit that referenced this issue Sep 20, 2024
@justsmth
Quell static-analysis concern about div-by-0 (#1866)
46394bd 
### Issues:
Addresses #1856

### Description of changes: 
Clarify pkcs8 logic so it doesn't trip up static analysis.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghenry @justsmth