Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quell static-analysis concern about div-by-0 #1866

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

justsmth
Copy link
Contributor

Issues:

Addresses #1856

Description of changes:

Clarify pkcs8 logic so it doesn't trip up static analysis.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 19, 2024 14:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (7090b90) to head (8705354).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   78.46%   78.46%   -0.01%     
==========================================
  Files         585      585              
  Lines       99457    99458       +1     
  Branches    14236    14238       +2     
==========================================
- Hits        78038    78035       -3     
- Misses      20784    20787       +3     
- Partials      635      636       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth enabled auto-merge (squash) September 20, 2024 18:54
@justsmth justsmth merged commit 46394bd into aws:main Sep 20, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants