Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisableHostPrefix doesn't change s3 client behavior #364

Closed
eriktate opened this issue Aug 24, 2019 · 0 comments · Fixed by #848
Closed

DisableHostPrefix doesn't change s3 client behavior #364

eriktate opened this issue Aug 24, 2019 · 0 comments · Fixed by #848
Labels
bug This issue is a bug.

Comments

@eriktate
Copy link

Related to #328

Version of AWS SDK for Go?

v0.10.0

Version of Go (go version)?

go version go1.13rc1 linux/amd64

What issue did you see?

When setting DisableHostPrefix to true in the aws.Config struct, the s3 client does not set ForcePathStyle to true. This causes problems when generating a config to target a local endpoint (localstack) for integration testing purposes.

If I am misunderstanding the purpose of the DisableHostPrefix flag, please let me know!

Steps to reproduce

  1. Create an aws.Config with DisableHostPrefix set to true.
  2. Create a s3.Client with that config.
  3. Check the ForcePathStyle flag on the s3.Client.
@KaibaLopez KaibaLopez added the bug This issue is a bug. label Sep 22, 2020
@jasdel jasdel mentioned this issue Oct 21, 2020
Merged
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
codegen: Add flag to direct if SDK is allowed to modify a custom endp…
a2a0b11 
…oint or not

Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member
directs if the SDK is allowed to modify the resolved endpoint to meet the
requirements of the API.  If `HostnameImmutable` is true, the SDK will not
attempt to modify the hostname via any customizations, or prefix behavior. Flag
 defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
codegen: Add flag to direct if SDK is allowed to modify a custom endp…
2592e95 
…oint or not

Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member
directs if the SDK is allowed to modify the resolved endpoint to meet the
requirements of the API.  If `HostnameImmutable` is true, the SDK will not
attempt to modify the hostname via any customizations, or prefix behavior. Flag
 defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
Merge pull request #848 from aws/jasdel/cust/EndpointResolver
6ecaaba 
Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API.  If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: Add flag to direct if SDK is allowed to modify a custom endpoint or not aws/aws-sdk-go-v2
2 participants
@KaibaLopez @eriktate