[S3][AccessPoints] Custom endpoints should not be modified when using accesspoints. #479
Labels
Comments
jasdel
added a commit
that referenced
this issue
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
that referenced
this issue
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
that referenced
this issue
Oct 27, 2020
Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
|
This issue was resolved with #848 that added an option to the Endpoint resolver for users to direct the SDK to not modify the custom endpoint. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation in the V2 SDK for support S3's AccessPoint feature will manipulate the resolved endpoint URL when an AccessPoint ARN is provided in a bucket parameter. This is not the intended behavior per the implementation in V1. This is due to the current endpoint resolver design preventing the ability to disambiguate an endpoint resolved from the default endpoint resolver in
aws/endpointfrom a custom endpoint provided by a user using a custom resolver such asaws/endpoints.EndpointResolverFuncThe text was updated successfully, but these errors were encountered: