retry: adds ability to return metadata for each request attempt
#1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
suggested changes
Jan 11, 2021
jasdel
suggested changes
Jan 12, 2021
…are to record response timing middleware
…r record response timing middleware
skotambkar
force-pushed
the
attemptmetadata
branch
from
e8e3a94
to
61db921
Compare
jasdel
approved these changes
Jan 13, 2021
skotambkar
force-pushed
the
attemptmetadata
branch
from
61db921
to
3b6fbc7
Compare
…y metric no longer returns an error if metadata is not present.
skotambkar
force-pushed
the
attemptmetadata
branch
from
61db921
to
15ebc25
Compare
This was referenced Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds requestAttempt and requestAttempts struct to handle metadata for all request attempts.
TODO