Action to setup CRT environment from action #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and see if that helps
…o setup_crt_ci_from_action
…e moment. Disable it for everything but Linux for now
…ntials everywhere
…o setup_crt_ci_from_action
graebm
reviewed
May 4, 2023
…th the buidler but hide the value if it is a secret
…/aws-crt-builder into setup_crt_ci_from_action
…e being passed right at the end by the builder? See if this helps
…/aws-crt-builder into setup_crt_ci_from_action
xiazhvera
approved these changes
May 24, 2023
|
Thanks! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a builder action (and helper file) to allow setting up all the environment variables needed for the CRT repositories in one builder action, rather than having multiple builder actions and different ways of setting up CI in each CRT repository. Instead, this adds a new builder action that can be run and will setup everything in one go.
Is based on discussion in #226 and internal discussion on #226.
Note: Leaving as a draft for now until it is working in actual CI to make sure everything needed is included.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.