Additional unit-tests and unit-test adjustment #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operation statistics test
…x so we can avoid running PKCS11 on it
…. Make most MQTT tests throw exceptions instead of errors
…n the test itself
sbSteveK
reviewed
May 24, 2023
sbSteveK
reviewed
May 24, 2023
sbSteveK
reviewed
May 24, 2023
sbSteveK
reviewed
May 24, 2023
sbSteveK
reviewed
May 24, 2023
sbSteveK
approved these changes
May 24, 2023
xiazhvera
reviewed
May 24, 2023
| AWS_STATIC_STRING_FROM_LITERAL(s_mqtt5_test_envName_iot_x509_ca, "AWS_TEST_MQTT5_IOT_CORE_X509_CA"); | ||
|
|
||
| // Needed to return "success" instead of skip in Codebuild so it doesn't count as a failure | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_mqtt5_test_envName_codebuild, "CODEBUILD_BUILD_ID"); |
There was a problem hiding this comment.
Just realized that the SKIPPED tests will be treated as failure for ctest, sorry that it caused the issue here.
The issue is fixed in CMake 3.9, while we are using 3.1 as the minimum requirement cross the SDKs. This is just a note that we could probably remove the check when we bump the minimum support for CMake to 3.9.
waahm7
reviewed
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds new unit tests to check for MQTT311 and MQTT5 connections for:
It uses a new CRT builder action here to setup the environment variables. Finally, it adjusts Codebuild to also use the CRT builder so everything has the same setup across the board.
*Note: This PR is always going to be marked as "failing" due to
aws-crt-cpp-integration-testsin Codebuild, as it uses an older container that doesn't support a new-enough version of Python. Theaws-crt-cpp-integration-tests-tmpis the equivalent, but with a newer container. I will updateaws-crt-cpp-integration-testswith the container prior to merge.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.