Correctly handle copy and delete operations on single objects #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberss
force-pushed
the
correctly-handle-single-object-operations
branch
from
6615c05
to
ac62d5a
Compare
|
LGTM! |
markjschreiber
approved these changes
Jul 18, 2024
|
New release is out (2.0.4) |
|
Thank you! |
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
The copy and delete code was currently treating
/foo/and/fooas a directory, which in the S3 context is incorrect (as perfectly summed up here). If the given path is not a directory, it should not be listing objects from S3 and returning all those that match the prefix. Rather, it should just be performing the copy/delete operation on that given object. This change adds a check for whether the given source is a directory and acts accordingly.