prefer Array#<< to creating a new array

and clean up test data part of flavorjones#191
b7kich · Aug 26, 2020 · ea6fe90 · ea6fe90
1 parent 50931f4
commit ea6fe90
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/loofah/html5/scrub.rb b/lib/loofah/html5/scrub.rb
@@ -91,7 +91,7 @@ def scrub_css(style)
                 end
               end.compact
               unless value.empty?
-                value += [CSS_IMPORTANT] if node[:important]
+                value << CSS_IMPORTANT if node[:important]
                 propstring = sprintf "%s:%s", name, value.join(" ")
                 sanitized_node = Crass.parse_properties(propstring).first
                 sanitized_tree << sanitized_node << CRASS_SEMICOLON

diff --git a/test/assets/testdata_sanitizer_tests1.dat b/test/assets/testdata_sanitizer_tests1.dat
@@ -486,10 +486,10 @@
     "rexml": "<div style='color: blue;'></div>"
   },
 
- {
-    "name": "style_attr_shorhand_important",
+  {
+    "name": "style_attr_shorthand_important",
     "input": "<div style=\"border: 2px dashed gray !important;\" />",
-    "output": "<div style='border:2px dashed gray !important;/>",
+    "output": "<div style='border:2px dashed gray !important;'/>",
     "xhtml": "<div style='border:2px dashed gray !important;'></div>",
     "rexml": "<div style='border:2px dashed gray !important;'></div>"
   },