Update to Babel 6?

[bebraw]

Given Babel 6 was just released, it might be nice to get babel-eslint on the board as well.

[hzoo]

Yeah been working on it but it will take a while since there's a lot of changes.

[bebraw]

@hzoo Great to hear. 👍

[iam4x]

@hzoo Are you working on a branch? I would like to help :)

[hzoo]

Yeah was doing it locally. #202 - Also have to make changes in acorn-to-esprima though (which should probably be renamed or maybe removed now)

[geminiyellow]

waiting for release, babel 6 change too much.

my eslint check give me this:

 0:0  error  Cannot read property 'tokTypes' of undefined

[ghost]

@geminiyellow same, disabled linting for now

[geminiyellow]

@sikhote yes, 4.1.4 not fix this error. waiting for #202 next release.

[hzoo]

All the current tests pass but I'm sure there are a bunch of issues - I can do a prerelease or something if people want to report bugs (or just checkout the pr and test it locally)

[geminiyellow]

@hzoo ok, please make a prerelease. i will try it locally.

[iam4x]

Thank's @hzoo, sorry was a lot busy though I could help 🙏

Going to test your branch with my projects ;)

[gajus]

@hzoo If there is a lot that needs to be done, it might be worth creating a todo list that people could contribute to.

[hzoo]

Good idea - although the todo list is mostly fixing up the ast in the acorn-to-esprima repo

[zackify]

I need this fixed as well, really weird

[hzoo]

made a prerelease https://github.com/babel/babel-eslint/releases/tag/v5.0.0-beta1

[j-walker23]

Thanks @hzoo, really appreciated!

[reintroducing]

I just tried v5.0.0-beta4 and am still getting the following:

ERROR in ./js/main.js
Module build failed: SyntaxError: /Users/mprzybylski/Desktop/webpack-test/node_modules/eslint-loader/index.js!/Users/mprzybylski/Desktop/webpack-test/js/main.js: Unexpected token (7:16)
  5 | import App from './components/App';
  6 |
> 7 | ReactDOM.render(<App />, document.querySelector('#wrapper'));

[hzoo]

Still getting - was it working before? Maybe something in your setup isn't working

[reintroducing]

I'm setting this up for the first time as a Browserify user trying to move to Webpack. You may be completely right that something in my setup may be wrong but I was never able to get this working with Babel 6 from when I ported everything over two weeks ago until now in trying the latest release. I've got everything working otherwise except the babel-eslint setup. This is my usage portions that pertain to it:

// in a common config
if (options.eslint) {
        settings.eslint = {
            formatter: require('eslint-friendly-formatter'),
            failOnError: true
        };
    }

// and in specific config that passes preLoaders to common
preLoaders: [
        {
            test: /\.jsx?$/,
            exclude: /node_modules/,
            loader: 'eslint'
        }
    ]

[hzoo]

Yeah if you haven't used it before that is a different issue from this - you need to specify the parser. "parser": "babel-eslint" http://eslint.org/docs/user-guide/configuring#specifying-parser

[reintroducing]

I have the parser specified in my .eslintrc:

{
    "parser": "babel-eslint",
    "env": {
        "browser": true,
        "node": false,
        "es6": true
    },
    "settings": {
        "ecmascript": 6
    },
    "ecmaFeatures": {
        "modules": true,
        "jsx": true
    },
...

I meant to say I haven't used Webpack before but I have used Browserify successfully (albeit I'm porting to Babel 6/Webpack together, didn't test Babel 6+ with my Browserify setup).

[hzoo]

As noted in #218 there is an issue with getters/setters

[hzoo]

Published [email protected] which hopefully fixes getters/setters. Going to close this issue for now so if there are other issues open a new issue with the relevant info