Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to babel 6 and enable transform-runtime #7

Closed
cesarandreu opened this issue Dec 2, 2015 · 2 comments
Closed

Upgrade to babel 6 and enable transform-runtime #7

cesarandreu opened this issue Dec 2, 2015 · 2 comments
Labels

Comments

@cesarandreu
Copy link
Contributor

See the following: babel is injecting helpers into each file and bloating my code!

You'll also need to pull in babel-runtime as a dependency.

@bvaughn
Copy link
Owner

bvaughn commented Dec 3, 2015

Upgrading to babel 6 breaks eslint:
path/to/file:0:0: Cannot read property 'tokTypes' of undefined

Looks like this is known: babel/babel-eslint/issues/199, standard/standard/issues/348

@bvaughn
Copy link
Owner

bvaughn commented Dec 3, 2015

I disabled eslint and went forward with the upgrade in a branch. I may have fat-fingered things somehow- I'm not a Webpack expert by any means- but after adding transform-runtime my dist increased from 68 KB to 91 KB.

@bvaughn bvaughn added the v5 label Feb 5, 2016
@bvaughn bvaughn removed the v5 label Feb 15, 2016
bvaughn added a commit that referenced this issue Feb 18, 2016
Upgraded to Babel 6.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants