This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix support for flow optional parameters in arrow functions #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cases like this:
var f = (x?) => {}
The main issue was that
parseMaybeConditional
was detecting the question mark as start of a ternary operator, and failed because it obviously is not one.To fix it parts of
parseMaybeConditional
was split intoparseConditional
and then overwritten in the flow plugin. There the main implementation is called, but syntax errors are catched and the state reseted to the question mark. The question mark can then be handled inparseParenItem
.The rest of the changes is to ensure that the optional operator only works in arrow functions.
Fixes T7096