This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fixes SyntaxError position with flow optional type #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -551,7 +551,7 @@ pp.parseParenAndDistinguishExpression = function (startPos, startLoc, canBeArrow | |||
| if (first) { | |||
| first = false; | |||
| } else { | |||
| this.expect(tt.comma); | |||
| this.expect(tt.comma, refNeedsArrowPos.start || null); | |||
There was a problem hiding this comment.
is this just 0 b/c there's let refNeedsArrowPos = { start: 0 }; at 550?
There was a problem hiding this comment.
This line is first triggered in the second iteration if (first) ... and refNeedsArrowPos is supplied to parseMaybeAssign on line 567 and this function might be changed it there.
Current coverage is 96.93% (diff: 100%)@@ master #65 diff @@
==========================================
Files 19 19
Lines 2922 2941 +19
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2832 2851 +19
Misses 90 90
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #19 was merged the column that babylon reports for SyntaxErrors involving a question mark was slightly off, because the initial SyntaxError was swallowed, a backtrack performed and then a new SyntaxError generated. For example:
babylon without flow reports the
=as unexpected, whereas with flow plugin it reportspas unexpected token.This PR fixes that by forwarding the position.