This repository has been archived by the owner on May 19, 2018. It is now read-only.
Improve error message on attempt to destructure named import #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
Jan 12, 2017
existentialism
commented
| Q | A |
|---|---|
| Bug fix? | N |
| Breaking change? | N |
| New feature? | Y |
| Deprecations? | N |
| Spec compliancy? | N |
| Tests added/pass? | Y |
| Fixed tickets | Fixes #258 |
| License | MIT |
Current coverage is 97.47% (diff: 100%)@@ master #288 diff @@
==========================================
Files 21 21
Lines 3991 3993 +2
Methods 488 488
Messages 0 0
Branches 1167 1168 +1
==========================================
+ Hits 3890 3892 +2
Misses 44 44
Partials 57 57
|
existentialism
force-pushed
the
issue258
branch
from
8ae2ea5
to
f231993
Compare
danez
approved these changes
Jan 12, 2017
|
Awesome stuff! Forgot I created the issue lol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.