Skip to content

Commit

Permalink
Remove the --gtest_filter=${porttest_filter} option for porttest
Browse files Browse the repository at this point in the history
When ${porttest_filter} is an empty string, no tests from porttest are
run. ${porttest_filter} is never set in OMR so it will always be an
empty string. Also, --gtest_filter=${porttest_filter} conflicts with
the GTEST_FILTER environment variable used by omrbuild.groovy. To avoid
the conflict and correctly run porttest, the --gtest_filter=${porttest_filter}
option is removed. porttest should consistently rely upon the GTEST_FILTER
environment variable.

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
  • Loading branch information
babsingh committed Apr 20, 2022
1 parent 7abfd05 commit 021db71
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fvtest/porttest/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
###############################################################################
# Copyright (c) 2017, 2021 IBM Corp. and others
# Copyright (c) 2017, 2022 IBM Corp. and others
#
# This program and the accompanying materials are made available under
# the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -165,7 +165,7 @@ endif()
if (NOT (OMR_OS_AIX OR OMR_OS_ZOS OR CMAKE_CROSSCOMPILING))
omr_add_test(
NAME porttest
COMMAND $<TARGET_FILE:omrporttest> --gtest_output=xml:${CMAKE_CURRENT_BINARY_DIR}/omrporttest-results.xml --gtest_filter=${porttest_filter}
COMMAND $<TARGET_FILE:omrporttest> --gtest_output=xml:${CMAKE_CURRENT_BINARY_DIR}/omrporttest-results.xml
)
endif()

Expand Down

0 comments on commit 021db71

Please sign in to comment.