Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porttest running 0 tests #6486

Closed
babsingh opened this issue Apr 20, 2022 · 0 comments · Fixed by #6487
Closed

porttest running 0 tests #6486

babsingh opened this issue Apr 20, 2022 · 0 comments · Fixed by #6487

Comments

@babsingh
Copy link
Contributor

babsingh commented Apr 20, 2022 •
edited
Loading

I rebased my OMR repo, and I was able to reproduce the error, which is mentioned in #6465 (comment). The introduction of "--gtest_filter=" at the end of the Test command causes 0 port tests to run. It is apparently affecting all PR builds. @0xdaryl None of the PR builds are correctly running porttest.

With the error

/root/omr/build/fvtest/porttest/omrporttest "--gtest_output=xml:/root/omr/build/fvtest/porttest/omrporttest-results.xml" "--gtest_filter="
Note: Google Test filter =
[==========] Running 0 tests from 0 test cases.
[==========] 0 tests from 0 test cases ran. (0 ms total)
[  PASSED  ] 0 tests.
[  ALL TESTS PASSED  ]

Without the error, after removing "--gtest_filter="

/root/omr/build/fvtest/porttest/omrporttest "--gtest_output=xml:/root/omr/build/fvtest/porttest/omrporttest-results.xml"
[==========] Running 237 tests from 20 test cases.
[----------] 1 test from PortInitializationTest
[----------] 1 test from PortInitializationTest (0 ms total)

[----------] 2 tests from PortFileTest
[----------] 2 tests from PortFileTest (0 ms total)

[----------] 8 tests from PortHeapTest
[----------] 8 tests from PortHeapTest (1099 ms total)

[----------] 8 tests from PortTest
...
babsingh added a commit to babsingh/omr that referenced this issue Apr 20, 2022
@babsingh
Fix the --gtest_filter option for omrporttest
5ec3dd5 
When ${porttest_filter} is an empty string, no tests from omrporttest
are run. Also, --gtest_filter input does not need to be wrapped in
quotation marks. The below changes will correctly run omrporttest
with an empty filter string:

--gtest_filter=*${porttest_filter}*
--gtest_filter=*Cuda*

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh mentioned this issue Apr 20, 2022
Merged
babsingh added a commit to babsingh/omr that referenced this issue Apr 20, 2022
@babsingh
Fix the --gtest_filter option for omrporttest
66d951f 
When ${porttest_filter} is an empty string, no tests from omrporttest
are run. Also, --gtest_filter input does not need to be wrapped in
quotation marks. The below changes will correctly run omrporttest
with an empty filter string:

--gtest_filter=*${porttest_filter}*
--gtest_filter=*Cuda*

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/omr that referenced this issue Apr 20, 2022
@babsingh
Remove the --gtest_filter=${porttest_filter} option for omrporttest
9039ecc 
When ${porttest_filter} is an empty string, no tests from omrporttest
are run. ${porttest_filter} is never set in OMR so it will always be
an empty string. Also, --gtest_filter=${porttest_filter} conflicts with
the GTEST_FILTER environment variable used by omrbuild.groovy. To avoid
the conflict and correctly run omrporttest, the
--gtest_filter=${porttest_filter} option is removed. omrporttest
should consistently rely upon the GTEST_FILTER environment variable.

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/omr that referenced this issue Apr 20, 2022
@babsingh
Remove the --gtest_filter=${porttest_filter} option for porttest
021db71 
When ${porttest_filter} is an empty string, no tests from porttest are
run. ${porttest_filter} is never set in OMR so it will always be an
empty string. Also, --gtest_filter=${porttest_filter} conflicts with
the GTEST_FILTER environment variable used by omrbuild.groovy. To avoid
the conflict and correctly run porttest, the --gtest_filter=${porttest_filter}
option is removed. porttest should consistently rely upon the GTEST_FILTER
environment variable.

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh changed the title omrporttest running 0 tests porttest running 0 tests Apr 20, 2022
babsingh added a commit to babsingh/omr that referenced this issue Apr 21, 2022
@babsingh
Remove the --gtest_filter=${porttest_filter} option for porttest
0ae5540 
When ${porttest_filter} is an empty string, no tests from porttest are
run. ${porttest_filter} is never set in OMR so it will always be an
empty string. Also, --gtest_filter=${porttest_filter} conflicts with
the GTEST_FILTER environment variable used by omrbuild.groovy. To avoid
the conflict and correctly run porttest, the --gtest_filter=${porttest_filter}
option is removed. porttest should consistently rely upon the GTEST_FILTER
environment variable.

Changed --gtest_filter="Cuda*" to --gtest_filter=*Cuda*. 0 tests are run.
This allows cuda_porttest to work correctly.

Fixes: eclipse#6486

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the --gtest_filter=${porttest_filter} option for porttest babsingh/omr
1 participant
@babsingh