Fix DropZone Preview on Rails 6.0.x (#263)

This adds Rails 6.0 compatibility for a change in CSS class calculation in ActionView::Helpers::TagHelper
baoagency · Aug 28, 2022 · d0200d8 · d0200d8
1 parent 0039dae
commit d0200d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/components/polaris/dropzone_component.html.erb b/app/components/polaris/dropzone_component.html.erb
@@ -87,12 +87,12 @@
     <template data-polaris-dropzone-target="previewTemplate">
       <%= tag.div(
         data: { polaris_dropzone_target: "preview" },
-        class: [
-          "Polaris-DropZone__Preview",
+        class: {
+          "Polaris-DropZone__Preview": true,
           "Polaris-DropZone__Preview--singleFile": !@multiple,
           "Polaris-DropZone__Preview--sizeMedium": @size == :medium,
           "Polaris-DropZone__Preview--sizeSmall": @size == :small,
-        ]
+        }
       ) do %>
         <% if @size.in?(%i[small]) %>
           <span class="target"></span>

diff --git a/test/components/polaris/dropzone_component_test.rb b/test/components/polaris/dropzone_component_test.rb
@@ -15,6 +15,14 @@ def test_default_dropzone
     end
   end
 
+  def test_dropzone_preview_template
+    rendered = render_inline(Polaris::DropzoneComponent.new(name: :file_input))
+    template = rendered.at_css("template[data-polaris-dropzone-target=previewTemplate] > *").to_html
+    template_page = Capybara::Node::Simple.new(template)
+
+    assert_selector template_page, ".Polaris-DropZone__Preview", visible: :all
+  end
+
   def test_dropzone_with_label
     render_inline(Polaris::DropzoneComponent.new(label: "Dropzone Label", label_hidden: false))