Fix DropZone Preview on Rails 6.0.x #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This adds Rails 6.0 compatibility for a change in CSS class calculation in ActionView::Helpers::TagHelper
|
Hi @kirillplatonov! We're fans of your gem here at @minifast. Thanks for all your hard work! I've got a Rails 6.0 backwards compatibility fix for the DropZone component. Please let me know if there are any desired changes! |
ohrite
changed the title
|
@ohrite thanks for the contribution 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
On Rails 6.0, ActionView::Helpers::TagHelper handles
tag.div(class: ["class-1", "class-2": true])differently than Rails 7. This results in an invalid class string rendered into the DropZone preview template.The class in question:
Before preview:
After preview:
What changed in this pull request?
This pull request uses a hash, rather than an array with a nested hash, to calculate the CSS classes for the DropZone Preview.
Tasks