[Cherrypick 4.2.1] Fix cquery with --built_test_only #13906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PriorityCategory.SOFTWARE_REQUIREMENT cannot be overridden by the user, unlike PriorityCategory.COMPUTED_DEFAULT. Also another existing flag that I think deserves the same enforcement. Re: concerns about aquery: none of this affects aquery because aquery doesn't inherit from TestCommand: https://github.com/bazelbuild/bazel/blob/a03442dd7408cdc6ef936f96cd3146ff6b3d09dd/src/main/java/com/google/devtools/build/lib/runtime/commands/CqueryCommand.java#L56 https://github.com/bazelbuild/bazel/blob/a03442dd7408cdc6ef936f96cd3146ff6b3d09dd/src/main/java/com/google/devtools/build/lib/runtime/commands/AqueryCommand.java#L48 PiperOrigin-RevId: 388330077 (cherry picked from commit 9f67cdf)
gregestren
approved these changes
Aug 26, 2021
This was referenced Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick request for 4.2.1 (#13558).
cquery: disable
--build_tests_only.PriorityCategory.SOFTWARE_REQUIREMENT cannot be overridden by the user, unlike
PriorityCategory.COMPUTED_DEFAULT. Also another existing flag that I think
deserves the same enforcement.
Re: concerns about aquery: none of this affects aquery because aquery doesn't
inherit from TestCommand:
bazel/src/main/java/com/google/devtools/build/lib/runtime/commands/CqueryCommand.java
Line 56 in a03442d
bazel/src/main/java/com/google/devtools/build/lib/runtime/commands/AqueryCommand.java
Line 48 in a03442d
PiperOrigin-RevId: 388330077
(cherry picked from commit 9f67cdf)