Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherrypick 4.2.1] Fix cquery with --built_test_only #13906

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[Cherrypick 4.2.1] Fix cquery with --built_test_only #13906

merged 1 commit into from
Aug 26, 2021

Commits on Aug 26, 2021

  1. cquery: disable --build_tests_only. 

    PriorityCategory.SOFTWARE_REQUIREMENT cannot be overridden by the user, unlike
PriorityCategory.COMPUTED_DEFAULT. Also another existing flag that I think
deserves the same enforcement.

Re: concerns about aquery: none of this affects aquery because aquery doesn't
inherit from TestCommand:

https://github.com/bazelbuild/bazel/blob/a03442dd7408cdc6ef936f96cd3146ff6b3d09dd/src/main/java/com/google/devtools/build/lib/runtime/commands/CqueryCommand.java#L56
https://github.com/bazelbuild/bazel/blob/a03442dd7408cdc6ef936f96cd3146ff6b3d09dd/src/main/java/com/google/devtools/build/lib/runtime/commands/AqueryCommand.java#L48

PiperOrigin-RevId: 388330077
(cherry picked from commit 9f67cdf)
    @gregestren @katre
    gregestren authored and katre committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    1da70f7 View commit details
    Browse the repository at this point in the history