Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate closure_repositories in favor of rules_closure_{dependencies,toolchains} #423

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Sep 14, 2019

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards #421

…s,toolchains}

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
@dslomov dslomov merged commit 5cc93ca into bazelbuild:master Sep 16, 2019
@Yannic
Copy link
Contributor Author

Yannic commented Sep 16, 2019

@dslomov Thanks for reviewing and merging? Can you cut a release? I'll send a follow-up to update the readme accordingly.

//cc @davido

@Yannic Yannic deleted the load_deps branch September 16, 2019 10:14
sgammon pushed a commit to Bloombox/rules_closure that referenced this pull request Oct 17, 2019
…s,toolchains} (bazelbuild#423)

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this pull request Dec 9, 2022
…s,toolchains} (bazelbuild#423)

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants