Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rules_closure conform to Style Guide for Rules #421

Open
2 of 4 tasks
Yannic opened this issue Sep 14, 2019 · 3 comments
Open
2 of 4 tasks

Make rules_closure conform to Style Guide for Rules #421

Yannic opened this issue Sep 14, 2019 · 3 comments

Comments

@Yannic
Copy link
Contributor

Yannic commented Sep 14, 2019 •
edited by alexeagle
Loading

Tracking bug for making rules_closure conform to Bazel's Style Guide for Rules.

Known issues:

  • Dependencies / Toolchains should be declared by rules_closure_{dependencies,toolchains} in closure/repositories.bzl: https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies
  • Tests should live in //tests
  • Repo description should be Closure rules for Bazel
  • Workspace should be named rules_closure (Note: There are probably too many existing users now, so this is going to be a wontFix issue).
Yannic added a commit to Yannic/rules_closure that referenced this issue Sep 14, 2019
@Yannic
Deprecate closure_repositories in favor of rules_closure_{dependencie…
9f55af3 
…s,toolchains}

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
@Yannic Yannic mentioned this issue Sep 14, 2019
Merged
dslomov pushed a commit that referenced this issue Sep 16, 2019
@Yannic @dslomov
Deprecate closure_repositories in favor of rules_closure_{dependencie…
5cc93ca 
…s,toolchains} (#423)

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards #421
sgammon pushed a commit to Bloombox/rules_closure that referenced this issue Oct 17, 2019
@Yannic @sgammon
Deprecate closure_repositories in favor of rules_closure_{dependencie…
daf5b04 
…s,toolchains} (bazelbuild#423)

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
@Yannic
Copy link
Contributor Author

Yannic commented Oct 18, 2019

@alexeagle Can you handle the repo description issue?

@alexeagle
Copy link
Contributor

Sure, done, thanks for picking this up.

@Yannic
Copy link
Contributor Author

Yannic commented Oct 18, 2019

Thank you!

Yannic added a commit to Yannic/rules_closure that referenced this issue Mar 3, 2020
@Yannic
Remove deprecated closure_repositories() macro
1188f10 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates bazelbuild#421
@Yannic Yannic mentioned this issue Mar 3, 2020
Merged
Yannic added a commit to Yannic/rules_closure that referenced this issue Mar 20, 2020
@Yannic
Remove deprecated closure_repositories() macro
acad554 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates bazelbuild#421
Yannic added a commit to Yannic/rules_closure that referenced this issue Mar 20, 2020
@Yannic
Remove deprecated closure_repositories() macro
a9c8952 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates bazelbuild#421
gkdn pushed a commit that referenced this issue Mar 20, 2020
@Yannic
Remove deprecated closure_repositories() macro (#476)
4925e62 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates #421
sgammon pushed a commit to sgammon/rules_closure that referenced this issue Nov 7, 2020
@Yannic @sgammon
Remove deprecated closure_repositories() macro (bazelbuild#476)
41eb490 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates bazelbuild#421
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this issue Dec 9, 2022
@Yannic @ptmphuong
Deprecate closure_repositories in favor of rules_closure_{dependencie…
6359c2f 
…s,toolchains} (bazelbuild#423)

This PR adds macros to closure/repositories.bzl to make rules_closure
more compliant with Bazel's Style Guide for Rules.

Working towards bazelbuild#421
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this issue Dec 9, 2022
@Yannic @ptmphuong
Remove deprecated closure_repositories() macro (bazelbuild#476)
28f16d4 
This was deprecated in favor of `rules_closure_dependencies()` and
`rules_closure_toolchains()` to be more consistent with other rules.
See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies

Updates bazelbuild#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @Yannic