Remove deprecated closure_repositories() macro #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkdn
reviewed
Mar 4, 2020
|
I did remove the warning that 0.10 is the last release to support |
|
Do you mind separating those two patches? |
Yannic
force-pushed
the
remove_old_deps_macro
branch
from
1188f10
to
acad554
Compare
This was deprecated in favor of `rules_closure_dependencies()` and `rules_closure_toolchains()` to be more consistent with other rules. See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies Updates bazelbuild#421
Yannic
force-pushed
the
remove_old_deps_macro
branch
from
acad554
to
a9c8952
Compare
|
Thanks, done! Split |
gkdn
approved these changes
Mar 20, 2020
sgammon
pushed a commit
to sgammon/rules_closure
that referenced
this pull request
Nov 7, 2020
This was deprecated in favor of `rules_closure_dependencies()` and `rules_closure_toolchains()` to be more consistent with other rules. See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies Updates bazelbuild#421
tfx-copybara
pushed a commit
to tensorflow/model-analysis
that referenced
this pull request
Aug 4, 2021
Also replaces closure_repositories with latest closure rules.(bazelbuild/rules_closure#476) We can drop zlib because the latest rules_closure includes protobuf 3.9 which solves the mentioned issue. PiperOrigin-RevId: 388590270
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
This was deprecated in favor of `rules_closure_dependencies()` and `rules_closure_toolchains()` to be more consistent with other rules. See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies Updates bazelbuild#421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated in favor of
rules_closure_dependencies()andrules_closure_toolchains()to be more consistent with other rules.See https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies
Updates #421