Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip: 20.3.4 -> 21.0.1 #412

Merged
merged 9 commits into from
Mar 30, 2021
Merged

Conversation

groodt
Copy link
Collaborator

@groodt groodt commented Feb 2, 2021

Note: No urgency to rush this. It introduces a breaking change where pip_install will only work for Python3+. If any release of rules_python needs to be done prior to prepare a final Python2 compatible release, it should be done before merging this.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Follow up to #405

This PR introduces pip 21.0.1 as the vendored version of pip. This version of pip will only support Python 3+ and is pip breaking away from Python 2 support since pip 21.0: https://pip.pypa.io/en/stable/news/#id1

My suggestion would be to first merge #405 and prepare a release or tag along with documentation around the pip_install Python 2 support. Then this PR can be rebased against upstream bazelbuild/rules_python and merged to support Python 3 pip_jnstall support only for future development.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Follow up to #405

This PR introduces pip 21.0.1 as the vendored version of pip. This version of pip will only support Python 3+ and is pip breaking away from Python 2 support since pip 21.0: https://pip.pypa.io/en/stable/news/#id1

My suggestion would be to first merge #405 and prepare a release or tag along with documentation around the pip_install Python 2 support. Then this PR can be rebased against upstream bazelbuild/rules_python and merged to support Python 3 pip_jnstall support only for future development.

Does this PR introduce a breaking change?

  • Yes
  • No

Python3 only support for pip_install due to pip upgrade.

@groodt
Copy link
Collaborator Author

groodt commented Feb 2, 2021

Build failure is due to CI running Python3.5 which is EOL.

pip 21.x dropped support for all Python 2 and Python 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants