-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setuptools: Bump version to 54.0.0 #422
Conversation
python/requirements.txt
Outdated
@@ -1,5 +1,5 @@ | |||
pip==9.0.3 | |||
setuptools==54.0.0 | |||
setuptools==44.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this wont let me set newer setuptools - versions available only seem to go to 44.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 44 was the last to support both Python 2 & 3. So until rules_python fully drops Python 2 support, it may be stuck with this version.
@@ -16,8 +16,8 @@ _RULE_DEPS = [ | |||
), | |||
( | |||
"pypi__setuptools", | |||
"https://files.pythonhosted.org/packages/ab/b5/3679d7c98be5b65fa5522671ef437b792d909cf3908ba54fe9eca5d2a766/setuptools-44.1.0-py2.py3-none-any.whl", | |||
"992728077ca19db6598072414fb83e0a284aca1253aaf2e24bb1e55ee6db1a30", | |||
"https://files.pythonhosted.org/packages/70/06/849cc805ac6332210083f2114a95b22ee252ce81ed4e1be4f1d2b87c9108/setuptools-54.0.0-py3-none-any.whl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 44 was the last to support both Python 2 & 3. So until rules_python fully drops Python 2 support, it may be stuck with this version.
does that also preclude this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, but I think the new pip_install
is only intended to support Python 3 (#409). The issue seems to be that there's also the older packaging rules still present, which support Python 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be really helpful if this were included from our pov, but my bazel knowledge is a bit limited so im not totally sure of the effect
I personally think this will work itself out and be easier to manage once the other train of PRs is merged as mentioned here #421 (comment) In summary:
This change can't really be done until the above is done. It might also be possible to include this as part of #412, but perhaps also as a fast-follow too, since it is an unrelated changed to #412. |
PR Checklist
Please check if your PR fulfills the following requirements:
.par
files. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
dependency update
What is the current behavior?
rules_python uses old version of setuptools which can break some packages on windows
Issue Number: #421
What is the new behavior?
rules_python uses current setuptools stable (54.0) which fixes above problem
Does this PR introduce a breaking change?
?
Other information