Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools: Bump version to 54.0.0 #422

Merged
merged 5 commits into from
Jun 25, 2021

Conversation

phlax
Copy link
Contributor

@phlax phlax commented Mar 2, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • [?] Tests for the changes have been added (for bug fixes / features)
  • [?] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

dependency update

What is the current behavior?

rules_python uses old version of setuptools which can break some packages on windows

Issue Number: #421

What is the new behavior?

rules_python uses current setuptools stable (54.0) which fixes above problem

Does this PR introduce a breaking change?

  • Yes
  • No

?

Other information

@@ -1,5 +1,5 @@
pip==9.0.3
setuptools==54.0.0
setuptools==44.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this wont let me set newer setuptools - versions available only seem to go to 44.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 44 was the last to support both Python 2 & 3. So until rules_python fully drops Python 2 support, it may be stuck with this version.

@@ -16,8 +16,8 @@ _RULE_DEPS = [
),
(
"pypi__setuptools",
"https://files.pythonhosted.org/packages/ab/b5/3679d7c98be5b65fa5522671ef437b792d909cf3908ba54fe9eca5d2a766/setuptools-44.1.0-py2.py3-none-any.whl",
"992728077ca19db6598072414fb83e0a284aca1253aaf2e24bb1e55ee6db1a30",
"https://files.pythonhosted.org/packages/70/06/849cc805ac6332210083f2114a95b22ee252ce81ed4e1be4f1d2b87c9108/setuptools-54.0.0-py3-none-any.whl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaliddell

Version 44 was the last to support both Python 2 & 3. So until rules_python fully drops Python 2 support, it may be stuck with this version.

does that also preclude this change ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but I think the new pip_install is only intended to support Python 3 (#409). The issue seems to be that there's also the older packaging rules still present, which support Python 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be really helpful if this were included from our pov, but my bazel knowledge is a bit limited so im not totally sure of the effect

@groodt
Copy link
Collaborator

groodt commented Mar 2, 2021

I personally think this will work itself out and be easier to manage once the other train of PRs is merged as mentioned here #421 (comment)

In summary:

  • Maintainers to cut new release that will be the last release with any semblance of Python 2.7 and 3.5 support for pip_install (it was never really supported, but kinda worked sometimes).
  • Remove Python 3.5 support from CI Removes Ubuntu 16.04 (and Python 3.5) support from CI #417
  • Upgrade to pip 21.0.1 (pip dropping Python 2.7 and this adds support for Big Sur and Apple Silicon wheels. The setuptools upgrade could possibly be added here tbh, since setuptools > 45 requires Python > 3.5. pip: 20.3.4 -> 21.0.1 #412

This change can't really be done until the above is done. It might also be possible to include this as part of #412, but perhaps also as a fast-follow too, since it is an unrelated changed to #412.

@hrfuller hrfuller merged commit 929d5a1 into bazelbuild:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants