Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools: Bump version to 54.0.0 #422

Merged
merged 5 commits into from
Jun 25, 2021
Merged

setuptools: Bump version to 54.0.0 #422

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2496ab
setuptools: Bump version to 54.0.0
phlax Mar 2, 2021
bec36a8
requirements
phlax Mar 2, 2021
548b3e3
Merge branch 'master' into setuptools-bump-version
Jun 8, 2021
7c9c2e0
Merge branch 'master' into setuptools-bump-version
hrfuller Jun 25, 2021
d977dfe
Merge branch 'master' into setuptools-bump-version
hrfuller Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/pip_install/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ _RULE_DEPS = [
),
(
"pypi__setuptools",
"https://files.pythonhosted.org/packages/ab/b5/3679d7c98be5b65fa5522671ef437b792d909cf3908ba54fe9eca5d2a766/setuptools-44.1.0-py2.py3-none-any.whl",
"992728077ca19db6598072414fb83e0a284aca1253aaf2e24bb1e55ee6db1a30",
"https://files.pythonhosted.org/packages/70/06/849cc805ac6332210083f2114a95b22ee252ce81ed4e1be4f1d2b87c9108/setuptools-54.0.0-py3-none-any.whl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaliddell

Version 44 was the last to support both Python 2 & 3. So until rules_python fully drops Python 2 support, it may be stuck with this version.

does that also preclude this change ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but I think the new pip_install is only intended to support Python 3 (#409). The issue seems to be that there's also the older packaging rules still present, which support Python 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be really helpful if this were included from our pov, but my bazel knowledge is a bit limited so im not totally sure of the effect

"d85b57c41e88b69ab87065c964134ec85b7573cbab0fdaa7ef32330ed764600a",
),
(
"pypi__wheel",
Expand Down