-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/improvements #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. explicit network policy for ingress and inter pod communication. 2. boost security for backend token validation to make sure only business bceid users are able to get in, a secondary step as the frontend token check happens before any of our backend token check. since all the routes are executed after this middleware(`passport.authenticate('jwt', { session: false })`). 3. some improvements to use optional chaining. Signed-off-by: Sukanya Rath <[email protected]>
…into chore/improvements
Signed-off-by: Sukanya Rath <[email protected]>
sukanya-rath
temporarily deployed
to
unit-test
December 6, 2023 23:37
— with
GitHub Actions
Inactive
sukanya-rath
temporarily deployed
to
unit-test
December 6, 2023 23:37
— with
GitHub Actions
Inactive
banders
reviewed
Dec 6, 2023
banders
reviewed
Dec 7, 2023
banders
approved these changes
Dec 7, 2023
Signed-off-by: Sukanya Rath <[email protected]>
sukanya-rath
temporarily deployed
to
unit-test
December 7, 2023 00:09
— with
GitHub Actions
Inactive
sukanya-rath
temporarily deployed
to
unit-test
December 7, 2023 00:09
— with
GitHub Actions
Inactive
[Pay Transparency Backend] SonarCloud Quality Gate failed. 0 Bugs 71.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below: