Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/improvements #90

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Chore/improvements #90

merged 4 commits into from
Dec 7, 2023

Commits on Dec 5, 2023

  1. chore improvements. 

    1. explicit network policy for ingress and inter pod communication.
2. boost security for backend token validation to make sure only business bceid users are able to get in, a secondary step as the frontend token check happens before any of our backend token check. since all the routes are executed after this middleware(`passport.authenticate('jwt', { session: false })`).
3. some improvements to use optional chaining.

Signed-off-by: Sukanya Rath <[email protected]>
    @sukanya-rath
    sukanya-rath committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    9cf2a1c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency … 

    …into chore/improvements
    @sukanya-rath
    sukanya-rath committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    973a8cf View commit details
    Browse the repository at this point in the history

  2. updated error message. 

    Signed-off-by: Sukanya Rath <[email protected]>
    @sukanya-rath
    sukanya-rath committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3c69eed View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. added optional chaining 

    Signed-off-by: Sukanya Rath <[email protected]>
    @sukanya-rath
    sukanya-rath committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    7e1e8be View commit details
    Browse the repository at this point in the history