Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEVA - Add report returned time stamp to report history #1287

Closed
2 tasks
kcabhar opened this issue Jan 17, 2023 · 1 comment
Closed
2 tasks

ZEVA - Add report returned time stamp to report history #1287

kcabhar opened this issue Jan 17, 2023 · 1 comment
Assignees
@JulianForeman
Labels
Angus Young Release 🎸 Release Tag Medium Medium Priority Story User story Tested :) Passed testing

Comments

@kcabhar
Copy link
Contributor

kcabhar commented Jan 17, 2023 •
edited by JulianForeman
Loading

Title:
Report returned time stamp added to report history

Description:
If a model year report gets returned to the vehicle supplier this information should be included in the report history panel, see wireframe.

The IDIR view has the additional line for when and who recommended the assessment to the director. The IDIR view also shows government staff names while the BCeID view only display generic 'Government of B.C.'

Wireframe:
IDIR view
https://preview.uxpin.com/ba292bb89debd007a79659b3f657c3649ade8efa#/pages/160425576?mode=fm

BCeID view
https://preview.uxpin.com/ba292bb89debd007a79659b3f657c3649ade8efa#/pages/160427035?mode=fm

Purpose and benefit to user:
This will also retain the original submission date to show that the report was originally submitted in time as the follow up report might be submitted back after the compliance date.

Acceptance Criteria:

  • Given I am an IDIR user I see a report returned line that includes who returned it as well as the date timestamp.
  • Given I am a BCeID user I see a report returned line that includes the date it was returned, but the name is abstracted to Government of BC.
@kcabhar kcabhar added Medium Medium Priority Story User story labels Jan 18, 2023
@kcabhar
Copy link
Contributor Author

kcabhar commented Feb 1, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @emi-hi @jig-patel @JulianForeman @tim738745 @vibhiquartech

@JulianForeman JulianForeman self-assigned this Jul 4, 2023
@kcabhar kcabhar added the Angus Young Release 🎸 Release Tag label Jul 5, 2023
tim738745 pushed a commit that referenced this issue Jul 10, 2023
@JulianForeman
Feat: Model Year Report Returned History Timestamp #1287 (#1850)
dc036da 
* Removed exclude for draft statuses as a government user, and added logic to properly capture when a report is returned to a supplier in the history.

* Cleanup

* Comment clarification

* Added optional operator for consistency across if statements
@airinggov airinggov added the Tested :) Passed testing label Jul 11, 2023
@kcabhar kcabhar closed this as completed Jul 12, 2023
tim738745 added a commit that referenced this issue Aug 11, 2023
@kuanfandevops @JulianForeman
@tim738745 @dependabot @AlexZorkin
Tracking pull request to merge release-1.48.0 to master (#1818)
42450bd 
* updates for 1.48.0

* update pr number

* update dev-build name

* Added logic to properly display addresses on the model year report summary page (#1820)

* Added check for reassessment/supplemental report to display text (#1823)

* add emergency pipeline to build 1.47.1

* ignore unit test

* rm backend tag

* Task - Credit Agreement Modal Confirmation #1788 (#1827)

* Added modal for confirming primary actions on credit agreements.

* Text change

* Text fix

* Feat: Model Year Report Returned History Timestamp #1287 (#1850)

* Removed exclude for draft statuses as a government user, and added logic to properly capture when a report is returned to a supplier in the history.

* Cleanup

* Comment clarification

* Added optional operator for consistency across if statements

* feat: zeva-1451 - limit credit applications to 2000 VINs (#1848)

* feat: zeva-1451 - limit credit applications to 2000 VINs

* minor change

* Bump django from 3.2.19 to 3.2.20 in /backend (#1847)

Bumps [django](https://github.com/django/django) from 3.2.19 to 3.2.20.
- [Commits](django/django@3.2.19...3.2.20)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: zeva-1739 - credits components unit tests (#1853)

* fix: added check to exclude gov users from signoff history on credit transfers (#1824)

Co-authored-by: Your Name <[email protected]>

* chore: zeva - delete squashed migrations (#1854)

* chore: zeva-1451 - update error message (#1855)

* Feat: Index Tables Pagination #1453 (#1856)

* Adding frontend pagination to index tables

* Preserving original page functionality

* feat: zeva-1831 - change credit reduction upon reassessment (#1858)

* feat: zeva-1831 - change credit reduction upon reassessment

* cleanup/fix unit test

* credit reduction reassessment refinements (#1860)

* fix: zeva-1859 - missing credit reduction lines (#1861)

* fix: zeva-1859 - missing credit reduction lines

* fix highlighting

* small fix

* fix: credit transaction page display logic (#1867)

* feat: zeva-1807 - MYR for small suppliers (#1866)

* feat: zeva-1807 - MYR for small suppliers

* small fix

* feat: zeva-1807 - MYR for small suppliers summary tab changes (#1871)

* chore: zeva-1743 - supplementary container unit tests (#1870)

* remove target branch

* Add data load to pipeline  (#1880)

* update pipeline readme

* update approval list

* Fix - Report History Bugs #1863 (#1886)

* Adding else if's to only include 1 history entry per loop

* Cleanup

* Comment clarification

* fix: zeva-1271 - summary page credit balance (#1885)

* fix: zeva-1661 - returned reassessment save error (#1882)

* add a create release pipeline

* update the branch name

* fix: zeva-1840 - reassessments default open (#1887)

* update the decrioption of new release branch creation

* fix: zeva-1888 - assessment tab fix (#1891)

* fix: zeva-1888 - assessment tab fix

* some refinements

* Task - Small Supplier MYR New Text #1872 (#1890)

* Removed checkboxes/altered text for small suppliers since they receive no credit reductions

* Fixes

* feat: enable supplementary reporting on prod (#1899)

* fix: zeva-1901 - MY report history bug fix (#1904)

* fix: zeva-1900 - reassessment history bug fix (#1903)

* Added logic on first loop to always capture the last history entry and then continue with it's regular process (#1905)

* Chore/resolve release branch conflicts tim (#1913)

* emergency release 1.47.1

* fix: added check to exclude gov users from signoff history on credit transfers (#1826)

Co-authored-by: Your Name <[email protected]>

* update to 1.48.0

---------

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>

* Emergency release 1.47.1 (#1825) (#1915)

* emergency release 1.47.1

* fix: added check to exclude gov users from signoff history on credit transfers (#1826)



---------

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: JulianForeman <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianForeman JulianForeman

Labels
Angus Young Release 🎸 Release Tag Medium Medium Priority Story User story Tested :) Passed testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@airinggov @JulianForeman @kcabhar