Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEVA - Index pages, React tables are missing the paging option #1453

Closed
4 tasks
airinggov opened this issue Feb 24, 2023 · 1 comment
Closed
4 tasks

ZEVA - Index pages, React tables are missing the paging option #1453

airinggov opened this issue Feb 24, 2023 · 1 comment
Assignees
@JulianForeman
Labels
Angus Young Release 🎸 Release Tag Bug Something isn't working Low Low priority Tested :) Passed testing

Comments

@airinggov
Copy link
Collaborator

airinggov commented Feb 24, 2023 •
edited by tim738745
Loading

Describe the Bug
As an IDIR or BCeID Zeva user the main index pages with React tables are missing the paging component to set amount of records per page etc.

BCeID
Compliance Reporting
Credit Applications, Transfers
ZEV Models
Administration
• Users

IDIR
Compliance Reporting
Credit Applications, Transfers, Agreement
ZEV Models
Vehicle Suppliers
• Users
Administration
• Users

Expected Behaviour
These index tables should have the paging component.

paging.png

Actual Behaviour
No paging component.

Implications
Users just get a long list that they can't adjust the amount of records displayed.

Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: Any

  1. Go to pages listed above
  2. Scroll to bottom of React tables

Acceptance Criteria

  • Given I am an IDIR user when I am viewing the vehicle supplier users, administration users, compliance reporting, credit applications, transfers, agreements, ZEV models or vehicle suppliers I should see the pages component to be able to set how many records I want to see on the page.
  • Given I am a BCeID user when I am viewing the compliance reporting, credit applications, transfers, ZEV models or vehicle suppliers I should see the pages component to be able to set how many records I want to see on the page.
  • Given I am a BCeID administrator when I am viewing the vehicle supplier users I should see the pages component to be able to set how many records I want to see on the page.

Development Checklist

  • Add the paging component and have it display correctly on the pages listed.

Additional Information
Please also choose a table that is performing the most poorly (loads the most slowly) and implement server-side pagination for it - this will entail managing the state of the table (page number, number of pages, filters, sorts). (This is a different card - #1842)
@airinggov airinggov added Bug Something isn't working Medium Medium Priority labels Feb 24, 2023
@kcabhar
Copy link
Contributor

kcabhar commented Mar 1, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @emi-hi @jig-patel @JulianForeman @tim738745 @vibhiquartech

@jdon-zev jdon-zev added Low Low priority and removed Medium Medium Priority labels May 24, 2023
@kcabhar kcabhar added the Angus Young Release 🎸 Release Tag label Jul 5, 2023
tim738745 pushed a commit that referenced this issue Jul 17, 2023
@JulianForeman
Feat: Index Tables Pagination #1453 (#1856)
6146593 
* Adding frontend pagination to index tables

* Preserving original page functionality
@airinggov airinggov added the Tested :) Passed testing label Jul 18, 2023
@kcabhar kcabhar closed this as completed Jul 25, 2023
tim738745 added a commit that referenced this issue Aug 11, 2023
@kuanfandevops @JulianForeman
@tim738745 @dependabot @AlexZorkin
Tracking pull request to merge release-1.48.0 to master (#1818)
42450bd 
* updates for 1.48.0

* update pr number

* update dev-build name

* Added logic to properly display addresses on the model year report summary page (#1820)

* Added check for reassessment/supplemental report to display text (#1823)

* add emergency pipeline to build 1.47.1

* ignore unit test

* rm backend tag

* Task - Credit Agreement Modal Confirmation #1788 (#1827)

* Added modal for confirming primary actions on credit agreements.

* Text change

* Text fix

* Feat: Model Year Report Returned History Timestamp #1287 (#1850)

* Removed exclude for draft statuses as a government user, and added logic to properly capture when a report is returned to a supplier in the history.

* Cleanup

* Comment clarification

* Added optional operator for consistency across if statements

* feat: zeva-1451 - limit credit applications to 2000 VINs (#1848)

* feat: zeva-1451 - limit credit applications to 2000 VINs

* minor change

* Bump django from 3.2.19 to 3.2.20 in /backend (#1847)

Bumps [django](https://github.com/django/django) from 3.2.19 to 3.2.20.
- [Commits](django/django@3.2.19...3.2.20)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: zeva-1739 - credits components unit tests (#1853)

* fix: added check to exclude gov users from signoff history on credit transfers (#1824)

Co-authored-by: Your Name <[email protected]>

* chore: zeva - delete squashed migrations (#1854)

* chore: zeva-1451 - update error message (#1855)

* Feat: Index Tables Pagination #1453 (#1856)

* Adding frontend pagination to index tables

* Preserving original page functionality

* feat: zeva-1831 - change credit reduction upon reassessment (#1858)

* feat: zeva-1831 - change credit reduction upon reassessment

* cleanup/fix unit test

* credit reduction reassessment refinements (#1860)

* fix: zeva-1859 - missing credit reduction lines (#1861)

* fix: zeva-1859 - missing credit reduction lines

* fix highlighting

* small fix

* fix: credit transaction page display logic (#1867)

* feat: zeva-1807 - MYR for small suppliers (#1866)

* feat: zeva-1807 - MYR for small suppliers

* small fix

* feat: zeva-1807 - MYR for small suppliers summary tab changes (#1871)

* chore: zeva-1743 - supplementary container unit tests (#1870)

* remove target branch

* Add data load to pipeline  (#1880)

* update pipeline readme

* update approval list

* Fix - Report History Bugs #1863 (#1886)

* Adding else if's to only include 1 history entry per loop

* Cleanup

* Comment clarification

* fix: zeva-1271 - summary page credit balance (#1885)

* fix: zeva-1661 - returned reassessment save error (#1882)

* add a create release pipeline

* update the branch name

* fix: zeva-1840 - reassessments default open (#1887)

* update the decrioption of new release branch creation

* fix: zeva-1888 - assessment tab fix (#1891)

* fix: zeva-1888 - assessment tab fix

* some refinements

* Task - Small Supplier MYR New Text #1872 (#1890)

* Removed checkboxes/altered text for small suppliers since they receive no credit reductions

* Fixes

* feat: enable supplementary reporting on prod (#1899)

* fix: zeva-1901 - MY report history bug fix (#1904)

* fix: zeva-1900 - reassessment history bug fix (#1903)

* Added logic on first loop to always capture the last history entry and then continue with it's regular process (#1905)

* Chore/resolve release branch conflicts tim (#1913)

* emergency release 1.47.1

* fix: added check to exclude gov users from signoff history on credit transfers (#1826)

Co-authored-by: Your Name <[email protected]>

* update to 1.48.0

---------

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>

* Emergency release 1.47.1 (#1825) (#1915)

* emergency release 1.47.1

* fix: added check to exclude gov users from signoff history on credit transfers (#1826)



---------

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: JulianForeman <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianForeman JulianForeman

Labels
Angus Young Release 🎸 Release Tag Bug Something isn't working Low Low priority Tested :) Passed testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@airinggov @JulianForeman @jdon-zev @kcabhar