Feat 2206 - Prevent commentator's name from displaying when updating information from comment #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tim738745
reviewed
Aug 19, 2024
| else: | ||
| #if the request user is not government and the commenter | ||
| #is government | ||
| return {'display_name': 'Government User'} |
There was a problem hiding this comment.
I see that this get_create_user() method used to return the data associated with a MemberSerializer instance, which consists of fields ('id', 'first_name', 'last_name', 'email', 'display_name', 'is_active', 'phone', 'roles', 'is_mapped'). Just wanted to make sure that returning only a display_name doesn't break anything in the frontend (e.g. if email is null it doesn't throw an error). As long as that's the case, looks good to me!
There was a problem hiding this comment.
I can't find any case with the vehicle comment serializer or sales submission comment serializer where email is used. I do want to make this more reusable as we probably will need to extend this to other features in which case we may want to add in the other fields.
There was a problem hiding this comment.
ok, sounds good, thanks for checking! I'll merge it in
| else: | ||
| #if the request user is not government and the commenter | ||
| #is government | ||
| return {'display_name': 'Government User'} |
tim738745
pushed a commit
that referenced
this pull request
Sep 17, 2024
kuanfandevops
added a commit
that referenced
this pull request
Sep 24, 2024
* initial 1.60.0 * update pr number * Update user-story-.md (#2198) * Task: Reassessment Credit Modifications #2195 (#2214) * Allowing all credit fields to me modified in reassessments * Cleanup * More cleanup * feat: removes idir names from sales submission and vehicle comments (#2217) * fix: 2215 - credit balances and recent reassessments (#2230) * for emily to look at - suggested solution for rounding issues (#2234) Co-authored-by: tim738745 <[email protected]> * chore: updates login instructions (removes references to creation_request table) (#2238) * remove test data load for pr build * update pr build * increase resource for pr build * only setup db for pr build * update pr build * New pipeline (#2229) * add test ci (#2242) * fix: removes unecessary data from transfer -- build-on-dev (#2241) * fix: removes unecessary data from transfer * fix: new user serializer passes only basic user info to frontend -get history modified so that approved and disapproved statuses created by government are excluded so that communications/status changes within government are not shown in network tab * removes id from user basic serializer * emergency release 1.59.1 * update for emergency release 1.59.1 * emergency release stuff (#2260) Co-authored-by: Kuan Fan <[email protected]> * change version number to 1.59.1 (#2261) * change package json number to 1.60.0 (#2262) * Emergency Release 1.59.1 (#2258) (#2263) * add emergency release-1.59.1 * add pull_request events * Update package.json * Transfer fix (#2244) * fix: removes unecessary data from transfer * fix: new user serializer passes only basic user info to frontend -get history modified so that approved and disapproved statuses created by government are excluded so that communications/status changes within government are not shown in network tab * removes id from user basic serializer * more fixes * small change + tests * Update version to be 1.59.1 in package.json --------- * Update emergency-release-build-1.59.1.yaml --------- Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: emi-hi <[email protected]> * revert post emergency release commits (#2264) * update approval list --------- Co-authored-by: Samuel Chukwuma Arawu <[email protected]> Co-authored-by: JulianForeman <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: tim738745 <[email protected]> Co-authored-by: tim738745 <[email protected]> Co-authored-by: emi-hi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes commentors name from vehicle and credit requests
if commenter is idir and current user is bceid:
show 'government user'
if commenter is bcied or current user is idir:
show details