ZEVA 2216: Fix - Rounding Error Between Credit Transaction Line Items and Detailed Credit Balance #2234
Conversation
|
|
@emi-hi, I'm actually a bit wary of this change because now Can we test this a bit more? For example, if a supplier is in deficit, what happens? Also, does everything work as expected on the BCeID side as well (e.g.g does the balance at the top right corner render correctly?) |
I've tested with the suppliers that had rounding issues and this fixes the issue on their side too, and created a deficit on another supplier by issuing a credit reduction, and the numbers look good to me. |
Co-authored-by: tim738745 <[email protected]>
* initial 1.60.0 * update pr number * Update user-story-.md (#2198) * Task: Reassessment Credit Modifications #2195 (#2214) * Allowing all credit fields to me modified in reassessments * Cleanup * More cleanup * feat: removes idir names from sales submission and vehicle comments (#2217) * fix: 2215 - credit balances and recent reassessments (#2230) * for emily to look at - suggested solution for rounding issues (#2234) Co-authored-by: tim738745 <[email protected]> * chore: updates login instructions (removes references to creation_request table) (#2238) * remove test data load for pr build * update pr build * increase resource for pr build * only setup db for pr build * update pr build * New pipeline (#2229) * add test ci (#2242) * fix: removes unecessary data from transfer -- build-on-dev (#2241) * fix: removes unecessary data from transfer * fix: new user serializer passes only basic user info to frontend -get history modified so that approved and disapproved statuses created by government are excluded so that communications/status changes within government are not shown in network tab * removes id from user basic serializer * emergency release 1.59.1 * update for emergency release 1.59.1 * emergency release stuff (#2260) Co-authored-by: Kuan Fan <[email protected]> * change version number to 1.59.1 (#2261) * change package json number to 1.60.0 (#2262) * Emergency Release 1.59.1 (#2258) (#2263) * add emergency release-1.59.1 * add pull_request events * Update package.json * Transfer fix (#2244) * fix: removes unecessary data from transfer * fix: new user serializer passes only basic user info to frontend -get history modified so that approved and disapproved statuses created by government are excluded so that communications/status changes within government are not shown in network tab * removes id from user basic serializer * more fixes * small change + tests * Update version to be 1.59.1 in package.json --------- * Update emergency-release-build-1.59.1.yaml --------- Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: emi-hi <[email protected]> * revert post emergency release commits (#2264) * update approval list --------- Co-authored-by: Samuel Chukwuma Arawu <[email protected]> Co-authored-by: JulianForeman <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: tim738745 <[email protected]> Co-authored-by: tim738745 <[email protected]> Co-authored-by: emi-hi <[email protected]>
work done by @tim738745