Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image_transport::CameraPublisher to publish synchronized Image and CameraInfo messages #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jschornak-bdai
Copy link
Contributor

The image_transport package provides specialized publishers that handle synchronizing Image and CameraInfo topics. This replaces the use of separate publishers in the image publisher node with image_transport::CameraPublisher publishers.

@skpawar1305
Copy link
Collaborator

The image_transport package provides specialized publishers that handle synchronizing Image and CameraInfo topics. This replaces the use of separate publishers in the image publisher node with image_transport::CameraPublisher publishers.

for network degradation (in Robocup Rescue League), we use ffmpeg image transport plugin, I tested this PR, it works perfect, how about readying the PR?

@jschornak-bdai
Copy link
Contributor Author

for network degradation (in Robocup Rescue League), we use ffmpeg image transport plugin, I tested this PR, it works perfect, how about readying the PR?

Thank you for testing! I'll mark it ready -- I wanted to experiment with switching image transport plugins first.

@skpawar1305
Copy link
Collaborator

for network degradation (in Robocup Rescue League), we use ffmpeg image transport plugin, I tested this PR, it works perfect, how about readying the PR?

Thank you for testing! I'll mark it ready -- I wanted to experiment with switching image transport plugins first.

btw, I've tested only rgb images, maybe check depth images as well
thank you👍

@ksharma-bdai ksharma-bdai removed their request for review July 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants