Skip to content

Commit

Permalink
Fix embroider scenarios
Browse files Browse the repository at this point in the history
  • Loading branch information
bendemboski committed May 10, 2021
1 parent 29bfb99 commit babcbf4
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 9 deletions.
26 changes: 24 additions & 2 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,30 @@ module.exports = async function () {
},
},
},
embroiderSafe(),
embroiderOptimized(),
embroiderSafe({
// https://github.com/embroider-build/embroider/issues/799
env: {
JOBS: '1',
},
// https://github.com/embroider-build/embroider/pull/792
npm: {
devDependencies: {
webpack: '^5.0.0',
},
},
}),
embroiderOptimized({
// https://github.com/embroider-build/embroider/issues/799
env: {
JOBS: '1',
},
// https://github.com/embroider-build/embroider/pull/792
npm: {
devDependencies: {
webpack: '^5.0.0',
},
},
}),
],
};
};
7 changes: 0 additions & 7 deletions tests/dummy/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ const browsers = [
'last 1 Safari versions',
];

const isCI = Boolean(process.env.CI);
const isProduction = process.env.EMBER_ENV === 'production';

if (isCI || isProduction) {
browsers.push('ie 11');
}

module.exports = {
browsers,
};

0 comments on commit babcbf4

Please sign in to comment.