Install webpack alongside @embroider/webpack when using @embroider/test-setup
#792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendemboski
added a commit
to bendemboski/ember-add-listener-helper
that referenced
this pull request
Apr 29, 2021
|
Thanks, good call. |
bendemboski
added a commit
to bendemboski/ember-add-listener-helper
that referenced
this pull request
Apr 29, 2021
rwjblue
changed the title
webpack alongside @embroider/webpackwebpack alongside @embroider/webpack when using @embroider/test-setup
bendemboski
added a commit
to bendemboski/ember-add-listener-helper
that referenced
this pull request
May 5, 2021
bendemboski
added a commit
to bendemboski/ember-add-listener-helper
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
webpackis a peer dependency to@embroider/webpacknow, the@embroider/test-setuppackage should also install that as part of the "Ember Try" configuration that it generates.