Track down incompatibility/race condition between JRuby and RSpec moc…

…ks in tests (#581)

.github/workflows/test.yml

@@ -91,7 +91,7 @@ jobs:
         uses: actions/cache@v1
         with:
           path: gemfiles/vendor/bundle
-          key: v1-bundler-${{ runner.os }}-${{ matrix.ruby }}-${{ hashFiles('**/Gemfile.lock') }}
+          key: v1-bundler-${{ runner.os }}-${{ matrix.ruby }}-${{ hashFiles('Gemfile.lock', 'gemfiles/*.gemfile.lock') }}
           restore-keys: |
             v1-bundler-${{ runner.os }}-${{ matrix.ruby }}-
       - name: Install Appraisal gems
@@ -106,6 +106,7 @@ jobs:
                                       --require ./spec/support/pre_documentation_formatter.rb \
                                       --format PreDocumentationFormatter
       - name: Run System tests
+        if: ${{ !contains(matrix.ruby, 'jruby') }}
         run: |
           bundle exec appraisal rspec --require ./spec/support/pre_documentation_formatter.rb \
                                       --format PreDocumentationFormatter \

spec/lib/good_job_spec.rb

@@ -64,6 +64,9 @@
       described_class.cleanup_preserved_jobs
 
       expect(ActiveSupport::Notifications).to have_received(:instrument).at_least(:once)
+
+      # Manually remove the stub to prevent the instrumentation from affecting multi-threaded teardown
+      ::RSpec::Mocks.space.proxy_for(ActiveSupport::Notifications).remove_stub(:instrument)
     end
   end
 end

spec/support/reset_good_job.rb

@@ -13,7 +13,7 @@
     THREAD_ERRORS.clear
     Thread.current.name = "RSpec: #{example.description}"
     GoodJob.on_thread_error = lambda do |exception|
-      THREAD_ERRORS << [Thread.current.name, exception]
+      THREAD_ERRORS << [Thread.current.name, exception, exception.backtrace]
     end
 
     example.run