Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track down incompatibility/race condition between JRuby and RSpec mocks in tests #581

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Track down incompatibility/race condition between JRuby and RSpec mocks in tests #581

merged 1 commit into from
Apr 25, 2022

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Apr 25, 2022 •
edited
Loading

Stubbing a class method, in this case ActiveSupport::Notifications.instrument seems to introduce some kind of multi-threaded race condition.

  • Include backtrace in thread error message
  • explicitly unstub class method stub inside of example
  • skip ignored System tests inside of Action runner too to save ~1 min of run time.

Screen Shot 2022-04-25 at 10 17 02 AM

@bensheldon bensheldon force-pushed the jruby-mocks branch 4 times, most recently from 73b41aa to 8283e92 Compare April 25, 2022 18:04
@bensheldon bensheldon marked this pull request as ready for review April 25, 2022 20:46
@bensheldon bensheldon merged commit c548fb7 into main Apr 25, 2022
@bensheldon bensheldon deleted the jruby-mocks branch April 25, 2022 20:46
bkeepers added a commit to bkeepers/good_job that referenced this pull request Apr 29, 2022
@bkeepers
Merge remote-tracking branch 'origin/main' into job-details
bcf4092 
* origin/main:
  Release good_job v2.14.1
  Temporarily disable Mass Action "Apply to all" because the action is badly scoped (bensheldon#583)
  Release good_job v2.14.0
  Add mass update operations for jobs to Dashboard (bensheldon#578)
  Track down incompatibility/race condition between JRuby and RSpec mocks in tests (bensheldon#581)
  Release good_job v2.13.2
  Namespaces assets per Rails docs (bensheldon#580)
  Release good_job v2.13.1
  Set up javascript importmaps for Dashboard; refactor Polling (bensheldon#574)
  Use toasts to show notices and alerts (bensheldon#577)
@bensheldon bensheldon added the refactor Code changes that do not introduce new features label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code changes that do not introduce new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bensheldon