Dashboard: show more details about jobs

engine/app/controllers/good_job/jobs_controller.rb

@@ -10,6 +10,7 @@ def index
     end
 
     def show
+      @job = ActiveJobJob.find(params[:id])
       @executions = GoodJob::Execution.active_job_id(params[:id])
                                       .order(Arel.sql("COALESCE(scheduled_at, created_at) DESC"))
       redirect_to root_path, alert: "Executions for Active Job #{params[:id]} not found" if @executions.empty?

engine/app/helpers/good_job/application_helper.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 module GoodJob
   module ApplicationHelper
-    def relative_time(timestamp)
-      text = timestamp.future? ? "in #{time_ago_in_words(timestamp)}" : "#{time_ago_in_words(timestamp)} ago"
+    def relative_time(timestamp, **args)
+      text = timestamp.future? ? "in #{time_ago_in_words(timestamp, **args)}" : "#{time_ago_in_words(timestamp, **args)} ago"
       tag.time(text, datetime: timestamp, title: timestamp)
     end
 
@@ -18,7 +18,7 @@ def status_badge(status)
                   "badge rounded-pill bg-danger"
                 end
 
-      content_tag :span, status.to_s, class: classes
+      content_tag :span, status.to_s.titleize, class: classes
     end
   end
 end

engine/app/views/good_job/jobs/show.html.erb

@@ -1,3 +1,88 @@
-<h1 class="mb-3">ActiveJob ID: <code><%= @executions.first.id %></code></h1>
+<div class="break-out bg-light border-bottom py-2 mb-3">
+  <div class="container-fluid pt-2">
+    <div class="d-flex align-items-center">
+      <div class="flex-fill">
+        <nav aria-label="breadcrumb">
+          <ol class="breadcrumb small mb-0">
+            <li class="breadcrumb-item"><%= link_to "Jobs", jobs_path %></li>
+            <li class="breadcrumb-item active" aria-current="page">ActiveJob ID: <code><%= @job.id %></code></li>
+          </ol>
+        </nav>
+        <h2 class="mb-1"><code><%= @job.job_class %></code></h2>
+        <div>
+          <%= status_badge @job.status %>
+          <span class="small text-muted">
+            <%= relative_time @job.finished_at || @job.performed_at || @job.scheduled_at || @job.created_at, include_seconds: true %>
+
+            <% if @job.runtime %>
+              • <%= @job.runtime.round(2) %>s runtime
+            <% end %>
+
+            <% if @job.executions_count > 1 %>
+              • <%= pluralize @job.executions_count, 'attempt' %>
+            <% end %>
+          </span>
+        </div>
+      </div>
+      <div>
+        <% job_reschedulable = @job.status.in? [:scheduled, :retried, :queued] %>
+        <%= button_to reschedule_job_path(@job.id), method: :put,
+            class: "btn btn-sm #{job_reschedulable ? 'btn-outline-primary' : 'btn-outline-secondary'}",
+            form_class: "d-inline-block",
+            disabled: !job_reschedulable,
+            aria: { label: "Reschedule job" },
+            title: "Reschedule job",
+            data: { confirm: "Confirm reschedule" } do %>
+          <%= render "good_job/shared/icons/skip_forward" %>
+          Reschedule
+        <% end %>
+
+        <% job_discardable = @job.status.in? [:scheduled, :retried, :queued] %>
+        <%= button_to discard_job_path(@job.id), method: :put, class: "btn btn-sm #{job_discardable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_discardable, aria: { label: "Discard job" }, title: "Discard job", data: { confirm: "Confirm discard" } do %>
+          <%= render "good_job/shared/icons/stop" %>
+          Discard
+        <% end %>
+
+        <%= button_to retry_job_path(@job.id), method: :put, class: "btn btn-sm #{@job.status == :discarded ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: @job.status != :discarded, aria: { label: "Retry job" }, title: "Retry job", data: { confirm: "Confirm retry" } do %>
+          <%= render "good_job/shared/icons/arrow_clockwise" %>
+          Retry
+        <% end %>
+      </div>
+    </div>
+  </div>
+</div>
+
+<table class="table">
+  <tr>
+    <th class="col-1">Queue</th>
+    <td>
+      <%= @job.queue_name %>
+        <% if @job.latency %>
+          <span class="text-muted small">(<%= @job.latency.round(2) %>s latency)</span>
+        <% end %>
+    </td>
+  </tr>
+  <tr>
+    <th>Priority</th>
+    <td><%= @job.priority %></td>
+  </tr>
+
+  <tr>
+    <th>Arguments</th>
+    <td><code><%= @job.serialized_params["arguments"].map(&:inspect).join(', ') %></code></td>
+  </tr>
+
+  <% if @job.recent_error %>
+    <tr>
+      <th>Error</th>
+      <td><pre class="text-danger my-0"><%= @job.recent_error %></pre></td>
+    </tr>
+  <% end %>
+
+  <tr>
+    <th>Params</th>
+    <td><%= tag.pre JSON.pretty_generate(@job.serialized_params) %></td>
+  </tr>
+</table>
 
 <%= render 'good_job/executions/table', executions: @executions %>

lib/good_job/active_job_job.rb

@@ -104,6 +104,20 @@ def status
       end
     end
 
+    # Time between when this job was expected to run and when it started running
+    def latency
+      now = Time.zone.now
+      expected_start = scheduled_at || created_at
+      actual_start = performed_at || now
+
+      actual_start - expected_start unless expected_start >= now
+    end
+
+    # Time between when this job started and finished
+    def runtime
+      (finished_at || Time.zone.now) - performed_at if performed_at
+    end
+
     # This job's most recent {Execution}
     # @param reload [Booelan] whether to reload executions
     # @return [Execution]

spec/lib/good_job/active_job_job_spec.rb

@@ -219,4 +219,45 @@ def perform(feline = nil, canine: nil)
       end
     end
   end
+
+  describe '#latency' do
+    it 'is nil for future scheduled job' do
+      job.scheduled_at = 1.minute.from_now
+      expect(job.latency).to be(nil)
+    end
+
+    it 'is distance between scheduled_at and now for past scheduled job' do
+      job.scheduled_at = 1.minute.ago
+      expect(job.latency).to be_within(0.01).of(Time.zone.now - job.scheduled_at)
+    end
+
+    it 'is distance between created_at and now for queued job' do
+      job.scheduled_at = nil
+      expect(job.latency).to be_within(0.01).of(Time.zone.now - job.created_at)
+    end
+
+    it 'is distance between created_at and performed_at for started job' do
+      job.scheduled_at = nil
+      job.performed_at = 10.seconds.ago
+      expect(job.latency).to eq(job.performed_at - job.created_at)
+    end
+  end
+
+  describe "#runtime" do
+    it 'is nil for queued job' do
+      expect(job.runtime).to be(nil)
+    end
+
+    it 'is distance between performed_at and now for started job' do
+      job.performed_at = 10.seconds.ago
+      job.finished_at = nil
+      expect(job.runtime).to be_within(0.01).of(Time.zone.now - job.performed_at)
+    end
+
+    it 'is distance between performed_at and finished_at' do
+      job.performed_at = 5.seconds.ago
+      job.finished_at = 1.second.ago
+      expect(job.runtime).to eq(job.finished_at - job.performed_at)
+    end
+  end
 end