Dashboard: show more details about jobs #575

bkeepers · 2022-04-20T06:20:10Z

This fixes #547 by updating jobs#show page to include status and other details about the job.

bensheldon

@bkeepers This is fantastic!

One request: would you be able to fit in the action buttons (reschedule discard, retry)?

bkeepers · 2022-04-20T18:59:55Z

One request: would you be able to fit in the action buttons (reschedule discard, retry)?

Absolutely. I was thinking actions could go on the top right.

bensheldon

👍 This looks good to me. I really appreciate you building out the page.

I'd love to land this in the same version with #576. Could you confirm that you're ok with me merging?

bkeepers · 2022-04-21T16:59:33Z

One request: would you be able to fit in the action buttons (reschedule discard, retry)?

Actions have been added.

I'd love to land this in the same version with #576. Could you confirm that you're ok with me merging?

I'd love to do a little more work on it if you're ok with waiting a few hours. There are a few things I still find awkward (Error always shows up, even if the most recent execution passes).

* origin/main: Remove executions from the dashboard (bensheldon#576)

bensheldon · 2022-04-21T17:11:13Z

@bkeepers no prob 👍

* origin/main: Release good_job v2.14.1 Temporarily disable Mass Action "Apply to all" because the action is badly scoped (bensheldon#583) Release good_job v2.14.0 Add mass update operations for jobs to Dashboard (bensheldon#578) Track down incompatibility/race condition between JRuby and RSpec mocks in tests (bensheldon#581) Release good_job v2.13.2 Namespaces assets per Rails docs (bensheldon#580) Release good_job v2.13.1 Set up javascript importmaps for Dashboard; refactor Polling (bensheldon#574) Use toasts to show notices and alerts (bensheldon#577)

* origin/main: Improve development instructions and tooling (rename bin/rails, add bin/appraisal) (bensheldon#590) Fix name of main branch in GH Action Include `ruby` version in development Gemfile; update to Ruby 3.0.4 (bensheldon#588) Replace test Instrumentation mocking with temporary subscriptions (bensheldon#589) Release good_job v2.14.2 Reintroduce fixed "Apply to all" mass action (bensheldon#586) Refactor Dashboard Live Poll javascript (bensheldon#582) Update development dependencies (bensheldon#584)

engine/app/helpers/good_job/application_helper.rb

bkeepers · 2022-04-29T01:06:26Z

engine/app/views/good_job/executions/_table.erb

-          <tr>
-            <td colspan="8" class="py-2 text-center text-muted">No executions found.</td>
-          </tr>
+<h5>Executions</h5>


FIXME: translation

bkeepers · 2022-04-29T01:07:13Z

engine/app/views/good_job/executions/_table.erb

+              <%= relative_time execution.finished_at || execution.performed_at || execution.scheduled_at || execution.created_at, include_seconds: true %>
+
+              <% if execution.runtime %>
+                • <div><%= format_duration execution.runtime %> runtime</div>


FIXME: translation for "runtime"

bkeepers · 2022-04-29T01:07:41Z

engine/app/views/good_job/executions/_table.erb

+                • <div><%= format_duration execution.runtime %> runtime</div>
+              <% end %>
+              <% if execution.latency %>
+                • <div><%= format_duration execution.latency %> latency</div>


FIXME: translation for "latency"

bkeepers · 2022-04-29T01:13:24Z

engine/app/views/good_job/jobs/show.html.erb

+          Discard
+        <% end %>
+
+        <%= button_to retry_job_path(@job.id), method: :put, class: "btn btn-sm #{@job.status == :discarded ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: @job.status != :discarded, aria: { label: "Retry job" }, title: "Retry job", data: { confirm: "Confirm retry" } do %>


FIXME: translation for "Retry job" and "Confirm retry"

bkeepers · 2022-04-29T01:13:40Z

engine/app/views/good_job/jobs/show.html.erb

+</div>
+
+<div class="my-4">
+  <h5>Arguments</h5>


FIXME: translation for "Arguments"

bkeepers · 2022-04-29T01:18:32Z

lib/good_job/execution.rb

+
+    def running?
+      performed_at? && !finished_at?
+    end


@bensheldon I moved #status to Execution because I wanted it for the jobs#show view, but this definition of #running? is different than in Job which uses advisory locks. Is this ok?

👍 Yep, that's ok. It's possible an execution record will be in a weird state as a result of a SIGKILL, but under normal operation this is the correct logic.

bkeepers · 2022-04-29T01:19:48Z

engine/app/helpers/good_job/application_helper.rb

+    end
+
+    def relative_time(timestamp, **args)
+      text = timestamp.future? ? "in #{time_ago_in_words(timestamp, **args)}" : "#{time_ago_in_words(timestamp, **args)} ago"


FIXME: not new to this PR, but "in …" and "… ago" need translations

bkeepers · 2022-04-29T01:21:12Z

engine/app/helpers/good_job/application_helper.rb

+    STATUS_ICONS = {
+      discarded: "exclamation",
+      finished: "check",
+      queued: "clock",


Should this use a different icon here?

What do you think of this icon for queued? https://icons.getbootstrap.com/icons/list-nested/

Another option would be to change "Scheduled" to be something like this calendar event and then use the Clock icon for queued.

This is like an advanced naming problem 🤣

Hmmm. The nested-list looks a little odd because everything else is in a circle:

I think I'm going with dash-circle. I also changed the color to warning (which is waaaay to bright, but we can color them later:

bensheldon · 2022-05-15T15:42:52Z

@bkeepers don't sweat tokenizing the strings for i18n; that can be deferred till later.

bensheldon

@bkeepers Thank you for the huge improvement 🎉

I'm going to accept this now and please point out any dangling problems I missed 😅

…ded_jobs` option to retain discarded jobs during cleanup (#597) * Adds the ability to delete jobs to the dashboard * Adds an option to preserve discarded jobs on cleanup * Adds ActiveJobJob#destroy_job and uses it * Renames delete -> destroy everywhere * Add Destroy button to top of Jobs#show page (redesigned in #575) Co-authored-by: Ben Sheldon [he/him] <[email protected]>

Update job details page

7e1e107

bensheldon reviewed Apr 20, 2022

View reviewed changes

bkeepers added 2 commits April 20, 2022 21:56

Test for #latency and #runtime

0b82c3e

Show actions on job page

66ccce0

bensheldon approved these changes Apr 21, 2022

View reviewed changes

bkeepers mentioned this pull request Apr 21, 2022

Dashboard: Use toasts to show notices and alerts #577

Merged

Merge remote-tracking branch 'origin/main' into job-details

c4df303

* origin/main: Remove executions from the dashboard (bensheldon#576)

bensheldon added the enhancement New feature or request label Apr 25, 2022

bkeepers added 8 commits April 27, 2022 12:09

Redesign executions list on jobs#show

07beb37

Rename duration helper to format_duration

4a259da

Add Execution#last_status_at

e4d268f

Use render_icon helper

571b3a0

Fix icon rendering

e017f31

Fix lint errors

2e06da6

bkeepers commented May 12, 2022

View reviewed changes

bkeepers and others added 5 commits May 12, 2022 12:45

Move duration format to translation

3ad152e

Lint specs after merging

251487d

Normalize en locale

3af97b9

Add translation key for status names

3ea7011

Machine translate strings; i18n-tasks doesn't like number formatters

53a50fb

bensheldon added 3 commits May 17, 2022 08:42

Use yellow dash-circle icon for "queued" status

592f034

Allow metadata to wrap on small viewports

6acdf6c

Remove unnecessary JobsController#show guards and queries

61fba24

bensheldon mentioned this pull request May 17, 2022

Adds the ability to delete jobs on the dashboard; add cleanup_discarded_jobs option to retain discarded jobs during cleanup #597

Merged

Move latency methods to Execution and rename

27277f2

bensheldon marked this pull request as ready for review May 18, 2022 13:47

bensheldon approved these changes May 18, 2022

View reviewed changes

bensheldon merged commit ee6716b into bensheldon:main May 18, 2022

bensheldon added a commit that referenced this pull request May 18, 2022

Add Destroy button to top of Jobs#show page (redesigned in #575)

bebb13c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard: show more details about jobs #575

Dashboard: show more details about jobs #575

bkeepers commented Apr 20, 2022 •

edited by bensheldon

Loading

bensheldon left a comment

bkeepers commented Apr 20, 2022

bensheldon left a comment

bkeepers commented Apr 21, 2022

bensheldon commented Apr 21, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bensheldon May 15, 2022

bkeepers Apr 29, 2022

bkeepers Apr 29, 2022

bensheldon May 14, 2022

bensheldon May 14, 2022

bensheldon May 17, 2022

bensheldon commented May 15, 2022

bensheldon left a comment

Dashboard: show more details about jobs #575

Dashboard: show more details about jobs #575

Conversation

bkeepers commented Apr 20, 2022 • edited by bensheldon Loading

bensheldon left a comment

Choose a reason for hiding this comment

bkeepers commented Apr 20, 2022

bensheldon left a comment

Choose a reason for hiding this comment

bkeepers commented Apr 21, 2022

bensheldon commented Apr 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bensheldon commented May 15, 2022

bensheldon left a comment

Choose a reason for hiding this comment

bkeepers commented Apr 20, 2022 •

edited by bensheldon

Loading