-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging for setuptools>=41.4 #163
Conversation
fe69c0d
to
c908d11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spending time to improve astor!
c908d11
to
f820f3f
Compare
What is the status of this PR? @jonringer @berkerpeksag |
it's ready to merge from my standpoint, and passes CI |
f820f3f
to
bd69767
Compare
had to modify the MANIFEST so that it exported the VERSION file when building a distribution, otherwise it would fail to open when installed |
- Temporarily using not-merged pull request from project. see berkerpeksag/astor#163 Closes #416
- Temporarily using not-merged pull request from project. see berkerpeksag/astor#163 Closes #416
660b9a8
to
3b857d3
Compare
3b857d3
to
30059da
Compare
looks like i had had a stale branch on my other computer, had to re-apply the Path -> os.path changes. |
Looks good to me fwiw. Are there co-maintainers to take this forward if @berkerpeksag doesn't have time? |
bump |
Please merge this fix in. |
Thanks for the PR and sorry for my late response! I've been dealing with a lot of $LIFE stuff lately. I'll add a note to changelog and release 0.8.1 hopefully tomorrow. |
@berkerpeksag I completely understand, :) |
0.8.1 is now published on PyPI: https://pypi.org/project/astor/0.8.1/ |
setup(**config['options']) is no longer valid, see #162 for error
closes #162