-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable running 'pip check' during sanity check for TensorFlow 2.0.0 #9308
Conversation
👍 Shall I base my fix on this or rebase this on my fix? |
@Flamefire I started looking into fixing this, see updates in 0faf07a, but we're not there yet... For the Python 3.7.4 on which
That should be done in a separate PR... |
The changes in
|
…nsions to make 'pip check' happy
3ca3d0a
to
0faf07a
Compare
This will be fixed by berkerpeksag/astor#163, see berkerpeksag/astor#162. Other method would be to use setuptools <41.4. I added the PR as a patch now and astor installs. BTW: Why did you add the dependencies dependencies like werkzeug? I thought EB/pip will do that itself? If not then there are more: From the configuration right before installing TF2:
Would be fun to figure out in which order to install all this :/ |
Ok found it. Why aren't we using |
Because then the installation is not reproducible later, To figure out the correct order of things, I've found this helpful: https://gist.github.com/boegel/fd9a636d652aa5c8e57778088e9c0a21 . |
See #9329 |
Thanks for that. I significantly improved that: https://gist.github.com/Flamefire/49426e502cd8983757bd01a08a10ae0d This now handles e.g. |
…a/2019b to avoid issues with astor + enable running of 'pip check' for every extension
Test report by @boegel |
Test report by @boegel |
Test report by @Flamefire |
Test report by @akesandgren |
The TensorFlow-1.13.1_lrt-flag.patch is missing from the fosscuda easyconfig in this PR |
And checksum for TensorFlow-1.14.0_fix-cuda-build.patch needs to be updated to match the already merged PR #9333 |
Test report by @boegel |
Test report by @akesandgren |
superseded by @Flamefire's PR #9338, so closing this one... |
Those things somehow didn't end up on the most recent easyconfig for 2.2... |
@surak Please open an issue on that, following things up in closed PRs is a nightmare. |
requires
easybuilders/easybuild-easyblocks#1853This will need more work, since
pip check
fails now with:see also @Flamefire's bug report #9306