Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Bevy's fork of the ecs_bench_suite to the appropriate folder #2062

Closed
alice-i-cecile opened this issue May 1, 2021 · 1 comment
Closed

Move Bevy's fork of the ecs_bench_suite to the appropriate folder #2062

alice-i-cecile opened this issue May 1, 2021 · 1 comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented May 1, 2021 •
edited
Loading

I went looking for the latest bevy-specific ecs_bench_suite code and could not quickly find it.

Ideally, this should be found (or linked) in our benches/bevy_ecs folder.

The most up-to-date version is currently found on @cart's GitHub page here: https://github.com/cart/ecs_bench_suite/tree/bevy-benches. The latest upstream code is here: https://github.com/rust-gamedev/ecs_bench_suite

Once this is done, please also update CONTRIBUTING.md (see #2040) with directions to the benchmarks and add appropriate documentation on how to run the benchmarks in the README of the benches folder.

I'm also not entirely sure why we have two layers of benches folders; perhaps someone else can chime in.
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation C-Performance A change motivated by improving speed, memory usage or compile times C-Code-Quality A section of code that is hard to understand or change labels May 1, 2021
@cart
Copy link
Member

cart commented May 1, 2021

I think it makes sense to have in-tree benches that are easy to run. We can probably just copy the benches from my ecs_bench_suite fork. However we should also drive the new benchmarks upstream. I'll probably get to it eventually, but if anyone else wants to pick that up, I'm cool with it.

@alice-i-cecile alice-i-cecile added the D-Trivial Nice and easy! A great choice to get started with Bevy label May 3, 2021
@james7132 james7132 mentioned this issue Mar 17, 2022
Closed
@bors bors bot closed this as completed in 08ef2f0 Mar 19, 2022
@cart cart mentioned this issue Mar 23, 2022
Closed
aevyrie pushed a commit to aevyrie/bevy that referenced this issue Jun 7, 2022
@james7132 @aevyrie
Add cart's fork of ecs_bench_suite (bevyengine#4225)
804238c 
# Objective
Better benchmarking for ECS. Fix bevyengine#2062.

## Solution
Port @cart's fork of ecs_bench_suite to the official bench suite for bevy_ecs, replace cgmath with glam, update to latest bevy.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@james7132 @ItsDoot
Add cart's fork of ecs_bench_suite (bevyengine#4225)
08b4880 
# Objective
Better benchmarking for ECS. Fix bevyengine#2062.

## Solution
Port @cart's fork of ecs_bench_suite to the official bench suite for bevy_ecs, replace cgmath with glam, update to latest bevy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Add cart's fork of ecs_bench_suite james7132/bevy
2 participants
@cart @alice-i-cecile