[Merged by Bors] - Add cart's fork of ecs_bench_suite

[james7132]

Objective

Better benchmarking for ECS. Fix #2062.

Solution

Port @cart's fork of ecs_bench_suite to the official bench suite for bevy_ecs, replace cgmath with glam, update to latest bevy.

[alice-i-cecile]

Looks good to me. We can revise these further in the future IMO.

[IceSentry]

I'm not sure if I'm doing something wrong, but if I clone this PR, go to the /benches folder and run cargo bench I get this error.

error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
   --> C:\Users\<user>\.cargo\registry\src\github.com-1ecc6299db9ec823\crossbeam-epoch-0.9.8\src\atomic.rs:314:6
    |
314 | impl<T: ?Sized + Pointable> Atomic<T> {
    |      ^
...
346 |     pub const fn null() -> Atomic<T> {
    |     -------------------------------- function declared as const here
    |
    = note: see issue #93706 <https://github.com/rust-lang/rust/issues/93706> for more information
    = help: add `#![feature(const_fn_trait_bound)]` to the crate attributes to enable

   Compiling cast v0.2.7
For more information about this error, try `rustc --explain E0658`.

I tried doing a cargo clean and I get the same error

[hymm]

I was able to run the tests just fine. Windows 10, rust 1.59.

[cart]

Awesome! I agree that we might ultimately want to tweak these to meet our own needs (instead of assuming ecs_bench_suite patterns are the right call). But having these tests in-tree makes optimizing bevy_ecs much easier. This is definitely a win.

[cart]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• check-benches
• check-doc
• check-markdown-links
• check-missing-examples-in-docs
• check-unused-dependencies
• ci
• markdownlint
• run-examples

[DJMcNab]

Sorry to do this, but I think we need to revert this. We don't have a license to include the code from ecs_bench_suite, which is all rights reserved.

We can seperately get in touch with @TomGillen to try and get such a license, but otherwise we can't use this.

[cart]

This was the right call, as we hadn't previously discussed this. But I think generally these fall under the "trivially reproducible / not novel" category of thing. From scratch impls would look pretty much the same. Couple that with me being the one that wrote most of the code here, and I think adding these isn't risky.

That being said, its better to ask and be safe.

@TomGillen, can we have permission to relicense the bevy ecs_bench_suite tests under bevy's dual MIT/Apache-2.0 license?

[TomGillen]

I don't have any problem with that. It should have had such a license in the first place, but it didn't occur to me that someone would want to embed the code into another project or use it as a library.

[cart]

Thanks @TomGillen!