Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reflect for the remaining Range types #5763

Closed
ItsDoot opened this issue Aug 22, 2022 · 1 comment
Closed

Implement Reflect for the remaining Range types #5763

ItsDoot opened this issue Aug 22, 2022 · 1 comment
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@ItsDoot
Copy link
Contributor

ItsDoot commented Aug 22, 2022 •
edited
Loading

What problem does this solve or what need does it fill?

We have a Reflect impl for Range presently, but there are other range types that aren't covered:

  • RangeInclusive (what I'm looking for presently)
  • RangeFrom
  • RangeTo
  • RangeToInclusive
  • RangeFull (probably not needed TBH, but listed for exhaustiveness)

What solution would you like?

Add Reflect impls for the types listed above.

What alternative(s) have you considered?

Use Range instead, however Range isn't always exactly correct for a given problem.
@ItsDoot ItsDoot added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 22, 2022
@ItsDoot
Copy link
Contributor Author

ItsDoot commented Aug 22, 2022

Should also consider changing Range from a reflect value to a struct.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types D-Trivial Nice and easy! A great choice to get started with Bevy and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 23, 2022
@maccesch maccesch mentioned this issue Aug 26, 2022
Closed
@bors bors bot closed this as completed in e9661be Aug 30, 2022
@cart cart mentioned this issue Aug 30, 2022
Closed
bors bot pushed a commit that referenced this issue Aug 30, 2022
@cart
Remove extra spaces from Range reflect impls (#5839)
dcdda4c 
# Objective

Remove extra spaces from Range reflect impls. Follow up to #5763 

## Solution

Remove extra spaces from Range reflect impls.
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@maccesch @james7132
Implemented Reflect for all the ranges (bevyengine#5806)
62e460e 
# Objective

Fixes bevyengine#5763

## Solution

Implemented as reflect value like the current `Range`. Is there a benefit to changing everything to a reflect struct?
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@cart @james7132
Remove extra spaces from Range reflect impls (bevyengine#5839)
65247cd 
# Objective

Remove extra spaces from Range reflect impls. Follow up to bevyengine#5763 

## Solution

Remove extra spaces from Range reflect impls.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@maccesch @ItsDoot
Implemented Reflect for all the ranges (bevyengine#5806)
0ce0ff7 
# Objective

Fixes bevyengine#5763

## Solution

Implemented as reflect value like the current `Range`. Is there a benefit to changing everything to a reflect struct?
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@cart @ItsDoot
Remove extra spaces from Range reflect impls (bevyengine#5839)
420b862 
# Objective

Remove extra spaces from Range reflect impls. Follow up to bevyengine#5763 

## Solution

Remove extra spaces from Range reflect impls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Implemented Reflect for all the ranges Synphonyte/bevy
2 participants
@alice-i-cecile @ItsDoot