[Merged by Bors] - Implemented Reflect for all the ranges
#5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
afonsolage
approved these changes
Aug 27, 2022
Weibye
approved these changes
Aug 27, 2022
Weibye
added
the
S-Ready-For-Final-Review
MrGVSV
approved these changes
Aug 29, 2022
| @@ -41,6 +41,11 @@ impl_reflect_value!(String(Debug, Hash, PartialEq, Serialize, Deserialize)); | |||
| impl_reflect_value!(Result<T: Clone + Reflect + 'static, E: Clone + Reflect + 'static>()); | |||
| impl_reflect_value!(HashSet<T: Hash + Eq + Clone + Send + Sync + 'static>()); | |||
| impl_reflect_value!(Range<T: Clone + Send + Sync + 'static>()); | |||
| impl_reflect_value!(RangeInclusive<T: Clone + Send + Sync + 'static>()); | |||
There was a problem hiding this comment.
Nit: Not that you have to, since none of the others do this, but you could replace some of those bounds with Reflect itself:
Suggested change
| impl_reflect_value!(RangeInclusive<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeInclusive<T: Clone + Reflect>()); |
Feel free to resolve this if you'd rather keep it as is haha
Edit: I guess this suggestion would require that the inner type is reflectable as well, which might be a good reason to hold off on applying it.
Comment on lines
43
to
+47
| impl_reflect_value!(Range<T: Clone + Send + Sync + 'static>()); | ||
| impl_reflect_value!(RangeInclusive<T: Clone + Send + Sync + 'static>()); | ||
| impl_reflect_value!(RangeFrom<T: Clone + Send + Sync + 'static>()); | ||
| impl_reflect_value!(RangeTo<T: Clone + Send + Sync + 'static>()); | ||
| impl_reflect_value!(RangeToInclusive<T: Clone + Send + Sync + 'static>()); |
There was a problem hiding this comment.
Nit: You have an extra space before each Send (likely due to Range having one too).
Suggested change
| impl_reflect_value!(Range<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeInclusive<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeFrom<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeTo<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeToInclusive<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(Range<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeInclusive<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeFrom<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeTo<T: Clone + Send + Sync + 'static>()); | |
| impl_reflect_value!(RangeToInclusive<T: Clone + Send + Sync + 'static>()); |
There was a problem hiding this comment.
I'd make these changes myself, but I've been disallowed from pushing to this branch :)
Worth blocking on as we'll just forget about it if we merge now.
cart
approved these changes
Aug 29, 2022
|
Eh actually I'll just follow up. No sense waiting around |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# Objective Fixes #5763 ## Solution Implemented as reflect value like the current `Range`. Is there a benefit to changing everything to a reflect struct?
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Reflect for all the rangesReflect for all the ranges
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#5763 ## Solution Implemented as reflect value like the current `Range`. Is there a benefit to changing everything to a reflect struct?
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5763 ## Solution Implemented as reflect value like the current `Range`. Is there a benefit to changing everything to a reflect struct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5763
Solution
Implemented as reflect value like the current
Range. Is there a benefit to changing everything to a reflect struct?