-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gizmo line styles #12394
Gizmo line styles #12394
Conversation
At this point I think we should break gizmos 2d_example and 3d_example in a few parts, the examples are getting pretty cramped |
I agree but I think this should wait until both #12252 and this are merged so we can have one "fancy_gizmos" example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. The problem with examples being too big can be in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested, though take my review with a grain of salt. I have little experience with gizmos or shaders. 😅
Co-authored-by: BD103 <[email protected]>
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1290 if you'd like to help out. |
Objective
Solution
GizmoLineStyle
and uses it in eachGizmoConfig
to configure the style of the line.line_width
of the corresponding line.Changelog
GizmoLineStyle
tobevy_gizmos
line_style: GizmoLineStyle
attribute toGizmoConfig
lines.wgsl
shader and the pipelines accordingly.Migration Guide
GizmoConfig
must now include theline_style
attributeAdditional information
Some pretty pictures :)
This is the 3d_gizmos example with/without
line_perspective
:And the 2d example: