Fix beta CI #12913
Merged
Fix beta CI #12913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I chose to remove the extended documentation for `TaskPool::executor`. It references `TaskPoolInner` which was added in bevyengine#384 when `bevy_tasks` was first created, but that struct was later removed in bevyengine#2250. James may be able to rewrite the comment, but I do not know enough about the task pool to write anything.
BD103
added
C-Bug
|
cc @Brezak :) |
james7132
approved these changes
Apr 9, 2024
Do you know if that's tracked on rust side? |
mockersf
approved these changes
Apr 9, 2024
Brezak
suggested changes
Apr 9, 2024
I've created rust-lang/rust#123677! |
Brezak
approved these changes
Apr 9, 2024
BD103
added
the
S-Ready-For-Final-Review
This was referenced Apr 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
# Objective - rust-lang/rust#123905 has been merged, so the workaround introduced in #12913 is no longer necessary. - Closes #12968 ## Solution - Remove unecessary `allow` attribute - This is currently blocked until Rust beta updates. - Last tested with `rustc 1.78.0-beta.7 (6fd191292 2024-04-12)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
TaskPoolBuilder::thread_name.TaskPoolreferencing the deletedTaskPoolInnerstruct.TaskPoolInner.)Appis already in scope forUpdateModedoc. (Extracted from Use same docs, for CI and deployment #12692.)